Re: FYI: settime.c doesn't compile on OSF1 V5.1 due to stime

[Jim Meyering]

Paul Eggert <address@hidden> wrote:
> That can't work, as it has unbalanced {.  Also, it's probably better

Thanks for catching that.
BTW, do you know what (if any) system ends up using that HAVE_STIME block?
I did run test builds on lots of systems, and none failed.

> just to return whatever error number stime and/or settimeofday return,
> rather than overwriting it with ENOSYS.  I installed the further patch
> enclosed below.
>
> However, I'm curious: if settime had this problem, why don't all the
> other places that take the address of tv_sec?  For example, date.c
> says "localtime (&when.tv_sec)".  So time_t is int but stime takes a
> long int *?

Right.  Ugly.

> Does this have something to do with OSF1 having both 64-bit and 32-bit
> times?  And settime is available only in the 64-bit flavor?  If so, is
> it possible to cajole OSF1 into using a 64-bit time_t type everywhere,
> instead of using it only with settime?  That would be better.

It does have options to switch between 32 and 64-bit modes,
but I didn't think it'd be worthwhile, for code that might
never be used.

> 2005-09-29  Paul Eggert  <address@hidden>
>
>       * settime.c (settime): Fix { typo in previous patch.  Also, don't
>       bother returning ENOSYS if settimeofday or stime fails; just let
>       them return whatever errno they want to return.