bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

removed uninit-64 test


From: Paul Eggert
Subject: removed uninit-64 test
Date: Sat, 24 Sep 2005 00:08:11 -0700
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)

CVS coreutils "make check" failed on 64-bit Solaris 8, because its
localtime function returns garbage in tm_year when time_t has an
outlandishly large year.  It is a bug, but it's not a coreutils bug.
Also, the test wouldn't work on a bug-free host with a 64-bit int.
Maybe there's a way to resurrect the test so that it doesn't have
these false reports, but I couldn't think of it.

2005-09-24  Paul Eggert  <address@hidden>

        * tests/misc/date (uninit-64): Remove this test.  It wasn't
        portable in theory (it doesn't work on hosts where 'int' is 64
        bits, example) or in practice (Solaris 8 localtime returns garbage
        in tm_year for the specified date, but that's not coreutils's
        fault).

--- date        16 Sep 2005 18:07:46 -0000      1.19
+++ date        24 Sep 2005 07:05:27 -0000      1.20
@@ -223,23 +223,6 @@ my @Tests =
      ['neg-secs', '-d @-22 +%05s', {OUT=>"-0022"}],
      ['neg-secs2', '-d @-22 +%_5s', {OUT=>"  -22"}],
 
-     # Before today's fix, date would print uninitialized data
-     # to standard output for an out-of-range date:
-     # $ date -d @$(echo 2^56-1|bc) 2> /dev/null | od -a -N3
-     # 0000000   p   4   6
-     # 0000003
-     ['uninit-64', '-d @72057594037927935',
-      {OUT=>''},
-      # Use ERR_SUBST to get around fact that the diagnostic
-      # you get on a system with 32-bit time_t is not the same as
-      # the one you get for a system where it's 64 bits wide:
-      # - date: time 72057594037927935 is out of range
-      # + date: invalid date address@hidden'
-      {ERR_SUBST => 's/.*//'},
-      {ERR => "\n"},
-      {EXIT => 1},
-     ],
-
      ['fill-1', '-d 1999-12-08 +%_3d', {OUT=>'  8'}],
      ['fill-2', '-d 1999-12-08 +%03d', {OUT=>'008'}],
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]