bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: verify.h: don't accept non-constant expressions


From: Jim Meyering
Subject: Re: verify.h: don't accept non-constant expressions
Date: Tue, 06 Sep 2005 13:12:44 +0200

Paul Eggert <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>
>> +# if __GNUC__ <= 2
>> +#  defined __builtin_constant_p(R) 1
>> +# endif
>
> Hmm, "defined"?

Indeed :)

> While looking into this, I found an alternate approach that should
> work with all ANSI C compilers, rather than relying on a special
> feature of GCC.  I installed this patch instead:
>
> 2005-09-06  Paul Eggert  <address@hidden>
>
>       * verify.h (verify_type__): Solve the problem by using a bit-field
>       rather than an array.

Good idea.  I prefer that, too.
Thanks.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]