Re: cygwin failing tests/mv/mv-special-1

[Paul Eggert]

Eric Blake <address@hidden> writes:

> we might as well dereference symlinks (one of the CANDIDATE_TMP_DIRS
> could be a cross-device symlink instead of a mount point)

Yes, thanks, that makes sense, though I see no reason to worry about
this for ".".

> Second, this is coreutils, so we have a reliable test(1) - the
> comment about `test -e' not being portable is irrelavant.  Third,
> mv-special-1 is not being careful that the named pipe is still a
> named pipe on the destination.

I think these points are addressed by my previous email and patch.

I installed the following slightly-more-conservative patch:

2005-04-19  Paul Eggert  <address@hidden>

        * tests/mv/setup (dot_mount_point): Use stat -L, in case the
        directory is actually a symbolic link.  Problem reported by
        Eric Blake.

--- setup       14 Apr 2005 20:35:34 -0000      1.13
+++ setup       19 Apr 2005 07:36:39 -0000      1.14
@@ -15,7 +15,7 @@ for d in $CANDIDATE_TMP_DIRS; do
   # Skip nonexistent directories.
   test -d $d || continue
 
-  d_mount_point=`stat -c %d $d`
+  d_mount_point=`stat -L -c %d $d`
 
   # Same partition?  Skip it.
   test x$d_mount_point = x$dot_mount_point && continue