bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: testsuite portability nit


From: Paul Eggert
Subject: Re: testsuite portability nit
Date: Sun, 17 Apr 2005 23:39:40 -0700
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.4 (gnu/linux)

I installed the following patch, in the hopes that it'd be relatively
simple and easy to maintain.  It skip the tests on the platforms with
the contrary-to-POSIX glitches.

2005-04-17  Paul Eggert  <address@hidden>

        Work around a couple of "make check" failures reported for Cygwin
        and ash by Eric Blake.
        * tests/install/basic-1: Skip this test if ../../src/dd isn't readable.
        * tests/install/trap: Skip this test if "trap '' CHLD" doesn't work.

--- basic-1     11 Aug 2004 23:41:59 -0000      1.11
+++ basic-1     18 Apr 2005 06:35:06 -0000      1.12
@@ -8,6 +8,11 @@ fi
 dir=dir
 file=file
 
+test -r ../../src/dd || {
+  echo >&2 "$0: ../../src/dd is not readable, so can't run this test"
+  exit 77
+}
+
 pwd=`pwd`
 tmp=inst-basic.$$
 trap 'status=$?; cd $pwd; rm -rf $tmp && exit $status' 0
--- trap        10 May 2004 15:13:29 -0000      1.1
+++ trap        18 Apr 2005 06:35:22 -0000      1.2
@@ -7,6 +7,12 @@ if test "$VERBOSE" = yes; then
   ginstall --version
 fi
 
+(trap '' CHLD) || {
+  echo >&2 "$0: the shell command \"trap '' CHLD\" does not work," \
+    "so can't run this test"
+  exit 77
+}
+
 pwd=`pwd`
 t0=`echo "$0"|sed 's,.*/,,'`.tmp; tmp=$t0/$$
 trap 'status=$?; cd $pwd; chmod -R u+rwx $t0; rm -rf $t0 && exit $status' 0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]