bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: possible patch for coreutils 5.1.1 failure on OSF 3.2C


From: Paul Eggert
Subject: Re: possible patch for coreutils 5.1.1 failure on OSF 3.2C
Date: 21 Jan 2004 12:15:03 -0800
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3

address@hidden (Paul Jarc) writes:

> This is still not quite right on systems with TAI clocks.

Good point.  Also, I notice that only the first part of my previous
patch was installed; presumably this is a typo?  Anyway, here's a
patch to the latest CVS snapshot that I have.

Index: ChangeLog
===================================================================
RCS file: /home/meyering/coreutils/cu/ChangeLog,v
retrieving revision 1.750
diff -p -u -r1.750 ChangeLog
--- ChangeLog   20 Jan 2004 22:44:46 -0000      1.750
+++ ChangeLog   21 Jan 2004 20:13:38 -0000
@@ -2,16 +2,22 @@
 
        * Version 5.1.2.
 
+2004-01-21  Paul Eggert  <address@hidden>
+
+       * tests/touch/relative: For 'ls' use TZ=UTC0, not TZ=utc (which isn't
+       portable).  Problem reported by Christian Krackowizer.  Also, use
+       TZ=UTC0 for the touch command too, in case we're on a system which
+       defaults to leap seconds.  Problem reported by Paul Jarc.  Remove
+       the previous patch to this file, as it's no longer needed.
+
 2004-01-20  Diego Biurrun  <address@hidden>
 
         * src/dircolors.hin: Add .mov to the list of media files.
 
 2004-01-19  Paul Eggert  <address@hidden>
 
-       * tests/touch/relative: Use TZ=UTC0, not TZ=utc (which isn't
-       portable).  Problem reported by Christian Krackowizer.  Also, use
-       +0000 rather than +0 to specify a time zone, as the documentation
-       requires four digits.
+       * tests/touch/relative: use +0000 rather than +0 to specify a time
+       zone, as the documentation requires four digits.
 
 2004-01-19  Jim Meyering  <address@hidden>
 
Index: tests/touch/relative
===================================================================
RCS file: /home/meyering/coreutils/cu/tests/touch/relative,v
retrieving revision 1.3
diff -p -u -r1.3 relative
--- tests/touch/relative        20 Jan 2004 09:19:37 -0000      1.3
+++ tests/touch/relative        21 Jan 2004 20:09:53 -0000
@@ -17,7 +17,11 @@ trap '(exit $?); exit $?' 1 2 13 15
 framework_failure=0
 mkdir -p $tmp || framework_failure=1
 cd $tmp || framework_failure=1
-touch --date='2004-01-16 05:26:38 +0000' f || framework_failure=1
+
+# The test time in the next command must not be in the 30-minute
+# window after a leap second, in case we're on a system where time_t
+# counts TAI rather than POSIX seconds.
+TZ=UTC0 touch --date='2004-01-16 05:26:38' f || framework_failure=1
 
 if test $framework_failure = 1; then
   echo "$0: failure in testing framework" 1>&2
@@ -29,7 +33,7 @@ fail=0
 # Set times back by 30 minutes.
 touch --ref f --date='-30 min' f || fail=1
 
-TZ=utc command ls -og --time-style=+%Y-%m-%dT%H:%M:%S f > out.1 || fail
+TZ=UTC0 command ls -og --time-style=+%Y-%m-%dT%H:%M:%S f > out.1 || fail
 sed 's/ f$//;s/.* //' out.1 > out
 
 cat <<\EOF > exp || fail=1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]