Re: Patch for coreutils 4.5.7 on Mac OS X

[Paul Eggert]

Petter Reinholdtsen <address@hidden> writes:

> Why does the code read '#if HAVE_SYSCTL_H then #include
> <sys/param.h>'?  This do not make sense.

It's a bit of a hack, but we don't know of any system where it breaks,
and the <sys/param.h> is certainly needed on some BSD systems.  Does
the code break on your system?  Your patch indicates that MacOS X has
sys/param.h so I don't see anything wrong about including it for your
host.

For the record, here's what happens on OpenBSD 3.0 if you omit the
<sys/param.h> include from src/uname.c.  The man page for sysctl(3)
says that you have to include <sys/param.h> before including
<sys/sysctl.h>.

In file included from /usr/include/sys/sysctl.h:50,
                 from uname.c:33:
/usr/include/sys/ucred.h:50: `NGROUPS' undeclared here (not in a function)
In file included from /usr/include/sys/sysctl.h:51,
                 from uname.c:33:
/usr/include/sys/proc.h:61: `MAXLOGNAME' undeclared here (not in a function)
/usr/include/sys/proc.h:86: syntax error before `int'
/usr/include/sys/proc.h:187: syntax error before `sigset_t'
/usr/include/sys/proc.h:194: `MAXCOMLEN' undeclared here (not in a function)
/usr/include/sys/proc.h:194: size of array `p_comm' has non-integer type
In file included from uname.c:33:
/usr/include/sys/sysctl.h:270: `MAXLOGNAME' undeclared here (not in a function)
*** Error code 1