Re: cfservd and LogAllConnections

[Bas van der Vlies]

Mark Burgess wrote:

> On 14 Aug, Bas van der Vlies wrote:
>
> > I have search the cfengine newsgroups and serveral people have already 
> > reported it. From the docs the follwing logs the connections:
> >    LogAllConnections = ( true )
> >
> > But that fails to work, because the check in cfservd.c is:
> > (GetMacroValue(CONTEXTID,"LogAllConnections") &&
> >     (strcmp(GetMacroValue(CONTEXTID,"LogAllConnections"),"on") == 0))
> >
> > Checks for the value = on. We have to adjust the source to support
> > the value = true or both (on,true) or we have to fix the docs?
>
>
>
> I have been trying to standardize to supporting both on and true
Oke. Is it an idea to convert the values (true|false) to (on|off)
in the AddMacroValue function. So we have to use "on" in src but we
can specifiy the other values in the cfengine configuration files.
In most places on/off is used. Only in on place it is different:

do.c:if (GetMacroValue(CONTEXTID,"EmptyResolvConf") && 
(strcmp(GetMacroValue(CONTEXTID,"EmptyResolvConf"),"true") == 0))

If positive i can change the code.
--
********************************************************************
*                                                                  *
*  Bas van der Vlies                     e-mail: address@hidden      *
*  SARA - Academic Computing Services    phone:  +31 20 592 8012   *
*  Kruislaan 415                         fax:    +31 20 6683167    *
*  1098 SJ Amsterdam                                               *
*                                                                  *
********************************************************************