[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: AppendIfNoSuchLine in 2.0.6
From: |
mark |
Subject: |
Re: AppendIfNoSuchLine in 2.0.6 |
Date: |
Mon, 21 Apr 2003 21:26:28 +0200 (MEST) |
I remember doing this. The claim was that in 2.0.5, the expression
itself was substited for the match, instead of the value of SetLine.
I think you are mixing up two things here:
AppendIfNoSuchLine
AppendIfNoLineMatching (requires SetLine)
Please check this.
M
On 21 Apr, Chip Seraphine wrote:
>
> I've run a lot more tests, and am finding that the AppendIfNoSuchLine
> function is definitely causing problems with 2.0.6 that do not happen in
> 2.0.5. Specifically, it appends the raw pattern to be matched instead
> of the previous SetLine value.
>
> A diff of editfiles.c between 2.0.6 (<) and 2.0.5 (>) shows this:
>
> 552c530
> < AppendItem(&filestart,expdata,NULL);
> ---
> > AppendItem(&filestart,EDITBUFF,NULL);
>
> I'm not overly familiar with the cfengine code, but this surely seems to
> be a deliberate change-- the edit buffer was replaced with the
> expression data, which is exactly what I am seeing in my files.
>
> Does anybody know why this was done? Is it safe to roll back this change?
>
>
>
> _______________________________________________
> Bug-cfengine mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/bug-cfengine
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Work: +47 22453272 Email: address@hidden
Fax : +47 22453205 WWW : http://www.iu.hio.no/~mark
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~