2.0.a16: cfservd doesn't properly check MD5 hashes

[David Bianco]

When cfagent asks cfservd to compute an MD5 checksum on a file in order to
see if it should be updated on the local system, cfservd always said the
submitted checksum didn't match the master file.  This caused cfagent to
copy every file for every run.  The debug output was showing:

ChecksumChanged: key /repository/etc/resolv.conf with data 
MD5=00000000000000000000000000000000

Turns out there was an apparently extraneous bzero() in cfservd.c.  I've 
included a patch below.

*** cfengine-2.0.a16/src/cfservd.c      Fri Jan 18 12:34:14 2002
--- cfengine-2.0.a16/BUILD/src/cfservd.c        Mon Feb 11 16:28:35 2002
***************
*** 2098,2104 ****
   
  Debug("CompareLocalChecksums(%s)\n",ChecksumPrint('m',digest));
  bzero(sendbuffer,bufsize);
- bzero(digest,EVP_MAX_MD_SIZE+1);
  
  if (ChecksumChanged(filename,digest,cfverbose,true,'m'))
     {
--- 2098,2103 ----

-- 
David J. Bianco, GSEC           <address@hidden>
Thomas Jefferson National Accelerator Facility

     The views expressed herein are soley those of the author and
            not those of SURA/Jefferson Lab or the US DOE.