cfengine 1.6.3 - bug in link handling

[Kim H. S|emosegaard]

Mark,

Since release 1.6.0 there's been a bug in the link handling where the 
additional classes in a "define" always becomes defined even if the
link has not been changed. The following example illustrates the bug:

        control:
          actionsequence = ( files links shellcommands )
        
        files:
          /tmp/cfengine-test-file
          action=touch
        
        links:
          /tmp/cfengine-test-link -> /tmp/cfengine-test-file
          type=symbolic define=LINK_UPDATED
        
        shellcommands:
          LINK_UPDATED::
            "/bin/echo LINK UPDATED"
          !LINK_UPDATED::
            "/bin/echo LINK NOT UPDATED"

Whenever the above script is run the class "LINK_UPDATED" will become 
defined.

The problem seems to be with the calls to AddMultipleClasses() in the 
LinkFiles() function but the logic of the function isn't clear to me 
so I'd prefer to have someone with more experience with the code look 
into it.

Sincerely,
--Kim
_____
Kim H. Søemosegaard <address@hidden> IT Systems Manager at diku.dk
Computer Science Department at the University of Copenhagen, Denmark