Bug report for cfengine

[Ted Knupke]

Hello all,

I was using the source code for cfengine 1.5.4 as test data
for a source-code analyzer that is under development, and
a couple of things popped up that look like bugs.

First, line 1027 of acl.c contains:
   sprintf("Unknown filesystem type in ACL %s\n",ip->name);
This statement is clearly wrong since the first argument to
sprintf is supposed to be a buffer and the format string is supposed
to be in the second argument.

Second, line 792 of image.c contains:
   Silent(OUTPUT,"Source file %s is < %d bytes in copy\n",sourcefile,ip->size);
which gets translated into a printf(...) by the pre-processor.  However,
here the first argument should be a format string.

Ted Knupke
The MITRE Corporation
202 Burlington Rd
Bedford, MA  01730
(781) 271-7537