Re: [GNU Bison 3.7.1] testsuite: 136 failed

[David Laxer]

## ------------- ##
## Test results. ##
## ------------- ##

647 tests were successful.
15 tests were skipped.

> On Aug 30, 2020, at 8:35 AM, Akim Demaille <akim@lrde.epita.fr> wrote:
> 
> 
> 
>> Le 30 août 2020 à 16:32, David Laxer <davidl@softintel.com> a écrit :
>> 
>> 
>> $ grep '#line' bison-3.7.1/tests/testsuite.dir/136/out/include/ast/loc.hh
>> #line 10 "x1.yy"
>> #line 59 "bar/include/ast/loc.hh"
>> #line 10 "x1.yy"
>> #line 305 "bar/include/ast/loc.hh"
>>> On Aug 30, 2020, at 1:38 AM, Akim Demaille <akim@lrde.epita.fr> wrote:
>>> 
>>> grep '#line' bison-3.7.1/tests/testsuite.dir/136/out/include/ast/loc.hh
>> 
> 
> Thanks.  That confirms the problem.  I'm installing the appended patch.
> I would appreciate if you could give a try to this tarball.  Thanks in 
> advance!
> 
> https://www.lrde.epita.fr/~akim/private/bison/bison-3.7.1.16-4ed13.tar.gz
> https://www.lrde.epita.fr/~akim/private/bison/bison-3.7.1.16-4ed13.tar.lz
> https://www.lrde.epita.fr/~akim/private/bison/bison-3.7.1.16-4ed13.tar.xz
> 
> 
> commit ba3d34aeba3baf2fe5a730f3d73fd004ae780f28
> Author: Akim Demaille <akim.demaille@gmail.com>
> Date:   Sun Aug 30 17:08:23 2020 +0200
> 
>    tests: beware of sed portability issues
> 
>    Reported by David Laxer <davidl@softintel.com>.
>    https://lists.gnu.org/r/bug-bison/2020-08/msg00027.html
> 
>    * tests/output.at: Don't use + with sed.
>    While at it, fix a quotation problem hidden by the use of '#'.
> 
> diff --git a/tests/output.at b/tests/output.at
> index 60267c2d..5af1e914 100644
> --- a/tests/output.at
> +++ b/tests/output.at
> @@ -759,7 +759,7 @@ AT_TEST([x1],
>          ])
> 
> # Check the CPP guard and Doxyen comments.
> -AT_CHECK([sed -ne 's/#line [0-9]\+ "/#line "/p;/INCLUDED/p;/\\file/{p;n;p;}' 
> out/include/ast/loc.hh], [],
> +AT_CHECK([[sed -ne 's/#line [0-9][0-9]* "/#line 
> "/p;/INCLUDED/p;/\\file/{p;n;p;}' out/include/ast/loc.hh]], [],
> [[ ** \file bar/include/ast/loc.hh
>  ** Define the x1::location class.
> #ifndef YY_YY_BAR_INCLUDE_AST_LOC_HH_INCLUDED
> @@ -771,7 +771,7 @@ AT_CHECK([sed -ne 's/#line [0-9]\+ "/#line 
> "/p;/INCLUDED/p;/\\file/{p;n;p;}' out
> #endif // !YY_YY_BAR_INCLUDE_AST_LOC_HH_INCLUDED
> ]])
> 
> -AT_CHECK([sed -ne 's/^#line [0-9]\+ "/#line 
> "/p;/INCLUDED/p;/\\file/{p;n;p;}' out/x1.hh], [],
> +AT_CHECK([[sed -ne 's/^#line [0-9][0-9]* "/#line 
> "/p;/INCLUDED/p;/\\file/{p;n;p;}' out/x1.hh]], [],
> [[ ** \file bar/x1.hh
>  ** Define the x1::parser class.
> #ifndef YY_YY_BAR_X1_HH_INCLUDED
>

smime.p7s
Description: S/MIME cryptographic signature