Re: Bison 3.6.1 released

[Akim Demaille]

Hi Dagobert,

> Le 12 mai 2020 à 10:30, Dagobert Michelsen <address@hidden> a écrit :
> 
> This is the log from the failing test:
> 
> 571. c++.at:100: testing C++ Variant-based Symbols Unit Tests ...
> ./c++.at:227: COLUMNS=1000; export COLUMNS;  bison --color=no -fno-caret -o 
> list.cc list.yy
> ======== Testing with C++ standard flags: ''
> ./c++.at:231: $CXX $CXXFLAGS $CPPFLAGS  $LDFLAGS -o list list.cc $LIBS
> stderr:
> stdout:
> ./c++.at:231:  $PREPARSER ./list
> stderr:
> Assertion failed: "int" != "int"
> Assertion failed: "int" != "int"

Gosh, I'm such an idiot...  Don't mention this to my kids or to my friends!
Nor my enemies actually.  If you ever talk about this in public, I'll deny
everything!

It's amazing the CI did not break on this.  *All* the compilers (or maybe
linkers) I used keep a single copy of all the equal string literals, whereas
yours doesn't.

I'll install this, and then go and hide myself from humanity.  And raise cattle.
Say Bisons.  They look nice in your house 
(https://www.youtube.com/watch?v=sxDlsfpBKqA).

commit 5ed46ff2123b70c314acb707a9b7b7d27cb7a981
Author: Akim Demaille <address@hidden>
Date:   Tue May 12 18:37:49 2020 +0200

    tests: don't use == to compare const char *...
    
    Reported by Dagobert Michelsen.
    https://lists.gnu.org/r/bug-bison/2020-05/msg00091.html
    
    * tests/c++.at: here.

diff --git a/tests/c++.at b/tests/c++.at
index 5789c8b0..e3a13224 100644
--- a/tests/c++.at
+++ b/tests/c++.at
@@ -161,8 +161,8 @@ int main()
   {
     parser::symbol_type s = parser::make_INT (12);
     assert_eq (s.kind (), parser::symbol_kind::S_INT);
-    assert_eq (parser::symbol_name (s.kind ()), "\"int\"");
-    assert_eq (s.name (), "\"int\"");
+    assert_eq (parser::symbol_name (s.kind ()), std::string ("\"int\""));
+    assert_eq (s.name (), std::string ("\"int\""));
     assert_eq (s.value.as<int> (), 12);
   }