Re: [Bison-Announce] Bison 3.5.91 released [beta]

[Akim Demaille]

> Le 3 mai 2020 à 11:27, Akim Demaille <address@hidden> a écrit :
> 
> 
> 
>> Le 2 mai 2020 à 17:05, Denis Excoffier <address@hidden> a écrit :
>> 
>>> On 2020-05-02 15:41, Akim Demaille wrote:
>>> 
>>> Denis,
>> Great!
> 
> :-P
> 
> Until we have something better, I'm installing this.
> 
> Cheers!
> 
> commit a279813664b0411fd219ae8a2f193acda47ac7c7
> Author: Akim Demaille <address@hidden>
> Date:   Sat May 2 07:23:58 2020 +0200
> 
>    tests: beware of mbswidth portability issues
> 
>    Shy away from these issues on Cygwin.
>    Reported Denis Excoffier.
>    https://lists.gnu.org/r/bug-bison/2020-05/msg00003.html
> 
>    * tests/diagnostics.at (Tabulations and multibyte characters): Split
>    in two.

That was wrong.  I'm installing this on top of it.

commit 32f44f4bfb33d856f24329914b9bc91451f4d634
Author: Akim Demaille <address@hidden>
Date:   Sun May 3 19:08:16 2020 +0200

    tests: really skip tricky multichar test on Cygwin
    
    In Autotest, anything outside AT_SETUP/AT_CLEANUP is discarded.
    
    * tests/diagnostics.at (AT_TEST): Accept a skip-if test.
    Use it to skip on cygwin.

diff --git a/tests/diagnostics.at b/tests/diagnostics.at
index 6c23ddb6..46af89c4 100644
--- a/tests/diagnostics.at
+++ b/tests/diagnostics.at
@@ -19,7 +19,7 @@ AT_BANNER([[Diagnostics.]])
 
 
 # AT_TEST($1: TITLE, $2: GRAMMAR, $3: EXIT-STATUS, $4: OUTPUT-WITH-STYLE,
-#         $5: EXTRA_ENV
+#         $5: EXTRA_ENV, $6: SKIP-IF)
 # -----------------------------------------------------------------------
 # Run Bison on GRAMMAR with debugging style enabled, and expect
 # OUTPUT-WITH-STYLE as diagnostics.
@@ -33,6 +33,9 @@ AT_KEYWORDS([diagnostics])
 locale=`locale -a | $EGREP '^en_US\.(UTF-8|utf8)$' | sed 1q`
 AT_SKIP_IF([test x == x"$locale"])
 
+m4_ifval([$6],
+[AT_SKIP_IF([$6])])
+
 AT_BISON_OPTION_PUSHDEFS
 
 AT_DATA_GRAMMAR([[input.y]], [$2])
@@ -261,11 +264,9 @@ input.y:17.4-17: <warning>warning:</warning> empty rule 
without %empty [<warning
 input.y: <warning>warning:</warning> fix-its can be applied.  Rerun with 
option '--update'. [<warning>-Wother</warning>]
 ]])
 
+
 # Likewise, but currently not portable to Cygwin.
 # https://lists.gnu.org/r/bug-bison/2020-05/msg00003.html.
-case `uname -a` in
-  (CYGWIN*);;
-  (*)
 AT_TEST([[Tabulations and multibyte characters]],
 [[%%
 e: {∇⃗×𝐸⃗ = -∂𝐵⃗/∂t}
@@ -276,9 +277,7 @@ e: {∇⃗×𝐸⃗ = -∂𝐵⃗/∂t}
       |    <warning>^~~~~~~~~~~~~~</warning>
       |    <fixit-insert>%empty</fixit-insert>
 input.y: <warning>warning:</warning> fix-its can be applied.  Rerun with 
option '--update'. [<warning>-Wother</warning>]
-]])
-;;
-esac
+]], [], [uname -a | grep -i cygwin])
 
 
 ## --------------- ##