>From 8f5aaa0e04185cc54cdc9c6747685f720ac355f3 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 5 Oct 2019 01:07:52 -0700 Subject: [PATCH 3/3] Avoid quiet conversion of pointer to bool * src/location.c (caret_set_file): * src/scan-code.l (contains_dot_or_dash): Do not quietly convert pointer to bool, as Oracle Developer Studio 12.6 complains and it is arguably confusing style anyway. --- src/location.c | 2 +- src/scan-code.l | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/location.c b/src/location.c index 6bb7ba3b..a5c37fbc 100644 --- a/src/location.c +++ b/src/location.c @@ -257,7 +257,7 @@ caret_set_file (const char *file) caret_free (); } } - return caret_info.file; + return !!caret_info.file; } void caret_init (void) diff --git a/src/scan-code.l b/src/scan-code.l index 5fae172a..563baf52 100644 --- a/src/scan-code.l +++ b/src/scan-code.l @@ -216,7 +216,7 @@ is_dot_or_dash (char ch) static inline bool contains_dot_or_dash (const char* p) { - return strpbrk(p, ".-"); + return !!strpbrk (p, ".-"); } /* Defines a variant of a symbolic name resolution. */ -- 2.17.1