bug-bison
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Null-Dereference bug in hash.c


From: Egor Pugin
Subject: Re: Null-Dereference bug in hash.c
Date: Mon, 9 Sep 2019 02:15:39 +0300

> Installed in master.

Hi,

Quick note about your changes. It seems all places with 'var =
hash_initialize()' have the following check:
if (!var)
    xalloc_die ();

Probably, it will be more... programmish if you make and add
xhash_initialize() function with that check in it.
DRY.

On Mon, 2 Sep 2019 at 19:57, Akim Demaille <address@hidden> wrote:
>
>
>
> > Le 2 sept. 2019 à 09:45, 江 祖铭 <address@hidden> a écrit :
> >
> > Thanks for your response.
> >
> > I am glad that the bug found by me has been confirmed.
> >
> > I think the fix is good and it can prevent the crash mentioned.
> >
> > Thanks.
>
> Installed in master.



-- 
Egor Pugin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]