bug-bison
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: (non)Use of C++ 11 constructs in skeleton


From: Akim Demaille
Subject: Re: (non)Use of C++ 11 constructs in skeleton
Date: Sun, 19 May 2019 11:19:33 +0200


> Le 19 mai 2019 à 11:02, Hans Åberg <address@hidden> a écrit :
> 
> 
>> On 19 May 2019, at 10:12, Akim Demaille <address@hidden> wrote:
>> 
>>> Le 19 mai 2019 à 04:02, Don Macpherson <address@hidden> a écrit :
>>> 
>>> Various places in the C++ skeleton have comments of the form:
>>> 
>>> /// This class is not copyable
>> 
>> Bison 3.4 is about to be published, I'm not going to do that now, but we'll 
>> do that afterwards.
> 
> Also a spelling error: copiable.

Doh...  I was rolling 3.4, and I just pushed the big red button right on time.

I'm installing this.  Thanks a lot Hans!

commit 75db37c56432014bf21bf92e817c65e2eb327a21
Author: Akim Demaille <address@hidden>
Date:   Sun May 19 11:16:20 2019 +0200

    fix: use copiable, not copyable
    
    Reported by Hans Åberg.
    http://lists.gnu.org/archive/html/bug-bison/2019-05/msg00017.html
    
    * data/skeletons/lalr1.cc, doc/bison.texi: here.

diff --git a/data/skeletons/lalr1.cc b/data/skeletons/lalr1.cc
index ef5d76f5..522e5471 100644
--- a/data/skeletons/lalr1.cc
+++ b/data/skeletons/lalr1.cc
@@ -218,7 +218,7 @@ m4_define([b4_shared_declarations],
 ]b4_token_constructor_define[
 
   private:
-    /// This class is not copyable.
+    /// This class is not copiable.
     ]b4_parser_class[ (const ]b4_parser_class[&);
     ]b4_parser_class[& operator= (const ]b4_parser_class[&);
 
diff --git a/doc/bison.texi b/doc/bison.texi
index d5913e8f..b200c5f7 100644
--- a/doc/bison.texi
+++ b/doc/bison.texi
@@ -11568,7 +11568,7 @@ Instead of using the built-in types you may use the 
@code{%define} variable
 The requirements over your @var{LocationType} are:
 @itemize
 @item
-it must be copyable;
+it must be copiable;
 
 @item
 in order to compute the (default) value of @code{@@$} in a reduction, the
@@ -11578,7 +11578,7 @@ parser basically runs
 @@$.end   = @@@var{N}.end; // The location of last right-hand side symbol.
 @end example
 @noindent
-so there must be copyable @code{begin} and @code{end} members;
+so there must be copiable @code{begin} and @code{end} members;
 
 @item
 alternatively you may redefine the computation of the default location, in
@@ -14473,7 +14473,7 @@ London, Department of Computer Science, TR-00-12 
(December 2000).
 @c LocalWords: YYENABLE bindtextdomain Makefile DEFS CPPFLAGS DBISON DeRemer
 @c LocalWords: autoreconf Pennello multisets nondeterminism Generalised baz ACM
 @c LocalWords: redeclare automata Dparse localedir datadir XSLT midrule Wno
address@hidden LocalWords: multitable headitem hh basename Doxygen fno filename
address@hidden LocalWords: multitable headitem hh basename Doxygen fno filename 
gdef
 @c LocalWords: doxygen ival sval deftypemethod deallocate pos deftypemethodx
 @c LocalWords: Ctor defcv defcvx arg accessors arithmetics CPP ifndef CALCXX
 @c LocalWords: lexer's calcxx bool LPAREN RPAREN deallocation cerrno climits
@@ -14494,14 +14494,17 @@ London, Department of Computer Science, TR-00-12 
(December 2000).
 @c LocalWords: errorVerbose subtype subtypes Wmidrule midrule's src rvalues
 @c LocalWords: automove evolutions Wother Wconflicts PNG lookaheads Acc sep
 @c LocalWords: xsltproc XSL xsl xhtml html num Wprecedence Werror fcaret gv
address@hidden LocalWords: fdiagnostics setlocale nullptr ast srcdir copyable 
iff drv
address@hidden LocalWords: fdiagnostics setlocale nullptr ast srcdir iff drv 
rgbWarning
 @c LocalWords: deftypefunx pragma Wnull dereference Wdocumentation elif ish
 @c LocalWords: Wdeprecated Wregister noinput yyloc yypos PODs sstream Wsign
 @c LocalWords: typename emplace Wconversion Wshorten yacchack reentrancy
address@hidden LocalWords: Relocatability exprs fixit Wyacc parseable fixits 
ffixit
address@hidden LocalWords: Relocatability exprs fixit Wyacc parseable fixits 
ffixit svg
 @c LocalWords: DNDEBUG cstring Wzero workalike POPL workalikes byacc UCB
 @c LocalWords: Penello's Penello Byson Byson's Corbett's CSD TOPLAS PDP
address@hidden LocalWords: Beazley's goyacc ocamlyacc SIGACT SIGPLAN
address@hidden LocalWords: Beazley's goyacc ocamlyacc SIGACT SIGPLAN 
colorWarning
address@hidden LocalWords: setcolor rgbError colorError rgbNotice colorNotice 
derror
address@hidden LocalWords: colorOff maincolor inlineraw darkviolet darkcyan 
dwarning
address@hidden LocalWords: dnotice copiable
 
 @c Local Variables:
 @c ispell-dictionary: "american"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]