Re: bison-3.2 make fails on Solaris 11.3 x86/64

[Akim Demaille]

> Le 30 oct. 2018 à 02:25, Kiyoshi KANAZAWA <address@hidden> a écrit :
> 
> Hello,
> Trying to build bison-3.2 on Solaris 11.3 x86/64, but failed.
> 
> % uname -a
> SunOS xxxx 5.11 11.3 i86pc i386 i86pc
> 
> % gcc --version
> gcc (GCC) 7.3.0
> % ar --version
> GNU ar (GNU Binutils) 2.31.1
> 
> 
> 
> % ./configure CC=gcc
> % make
>   :
>   CC       lib/vsprintf.o
>   CC       lib/xmemdup0.o
>   AR       lib/libbison.a

Bummer…

I have installed the following patch.  Could you please try this tarball?
Thanks in advance.

https://www.lrde.epita.fr/~akim/private/bison/bison-3.2.3-5d07f.tar.gz
https://www.lrde.epita.fr/~akim/private/bison/bison-3.2.3-5d07f.tar.xz


commit e605ad9679b583bf7e09afe00daf23e0dfa6c823
Author: Akim Demaille <address@hidden>
Date:   Tue Oct 30 06:55:47 2018 +0100

    build: fix use of gnulib Make variables
    
    Reported by Kiyoshi Kanazawa.
    http://lists.gnu.org/archive/html/bug-bison/2018-10/msg00048.html
    
    * lib/local.mk (lib_libbison_a_LIBADD): Merge into...
    * src/local.mk (src_bison_LDADD): here.

diff --git a/THANKS b/THANKS
index 3437e808..7254bb3f 100644
--- a/THANKS
+++ b/THANKS
@@ -84,6 +84,7 @@ Juan Manuel Guerrero      address@hidden
 Kees Zeelenberg           address@hidden
 Keith Browne              address@hidden
 Ken Moffat                address@hidden
+Kiyoshi Kanazawa          address@hidden
 Laurent Mascherpa         address@hidden
 Lie Yan                   address@hidden
 Magnus Fromreide          address@hidden
diff --git a/lib/local.mk b/lib/local.mk
index aec635a8..18c0953d 100644
--- a/lib/local.mk
+++ b/lib/local.mk
@@ -45,15 +45,6 @@ lib_libbison_a_SOURCES +=                       \
   lib/path-join.h                               \
   lib/path-join.c
 
-lib_libbison_a_LIBADD +=                        \
-  $(ISNAND_LIBM)                                \
-  $(ISNANF_LIBM)                                \
-  $(ISNANL_LIBM)                                \
-  $(LDEXPL_LIBM)                                \
-  $(LDEXP_LIBM)                                 \
-  $(LIB_CLOCK_GETTIME)                          \
-  $(LIB_GETHRXTIME)
-
 # The Yacc compatibility library.
 if ENABLE_YACC
   lib_LIBRARIES = lib/liby.a
diff --git a/src/local.mk b/src/local.mk
index 0651aac1..6d5adfd9 100644
--- a/src/local.mk
+++ b/src/local.mk
@@ -104,9 +104,19 @@ BUILT_SOURCES +=                                \
   src/scan-gram.c                               \
   src/scan-skel.c
 
+# Although conceptually most of these guys would make more sense in the
+# definition of libbison, beware that they might expand as flags such as
+# `-lm`.  Keep them here.  Or use a Libtool convenience library.
 src_bison_LDADD =                               \
+  $(ISNAND_LIBM)                                \
+  $(ISNANF_LIBM)                                \
+  $(ISNANL_LIBM)                                \
+  $(LDEXPL_LIBM)                                \
+  $(LDEXP_LIBM)                                 \
   $(LIBINTL)                                    \
   $(LIBTHREAD)                                  \
+  $(LIB_CLOCK_GETTIME)                          \
+  $(LIB_GETHRXTIME)                             \
   lib/libbison.a