bug-bison
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] build: avoid warnings about set-but-not-used variables


From: Jim Meyering
Subject: [PATCH] build: avoid warnings about set-but-not-used variables
Date: Fri, 06 Jan 2012 14:06:25 +0100

I built bison (latest from git/master) today and saw a few warnings.
I've attached the obvious fix for three of them.
It simply removes the decl and set of each variable.
This ensures that the fix induces no semantic change,
since no removed "set" statement has any side effect.
The result still passes "make check".
(though "make syntax-check" fails, due to copyrights and other nits)


>From 89d4466b6bcd2cf3eb995a087306c01a425bb5c9 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Fri, 6 Jan 2012 13:55:11 +0100
Subject: [PATCH] build: avoid warnings about set-but-not-used variables

* lib/bitset_stats.c (bitset_stats_list): Remove declaration
and set of unused local, "type".
* lib/ebitset.c (ebitset_init): Likewise, for "size".
* lib/lbitset.c (lbitset_not): Likewise, for "elt".
---
 ChangeLog          |    8 ++++++++
 lib/bitset_stats.c |    2 --
 lib/ebitset.c      |    5 -----
 lib/lbitset.c      |    5 -----
 4 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 76397fb..234df12 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2012-01-06  Jim Meyering  <address@hidden>
+
+       build: avoid warnings about set-but-not-used variables
+       * lib/bitset_stats.c (bitset_stats_list): Remove declaration
+       and set of unused local, "type".
+       * lib/ebitset.c (ebitset_init): Likewise, for "size".
+       * lib/lbitset.c (lbitset_not): Likewise, for "elt".
+
 2011-08-21  Joel E. Denny  <address@hidden>

        lalr1.cc: remove trailing comma from enumerator list.
diff --git a/lib/bitset_stats.c b/lib/bitset_stats.c
index 216bfd9..02d5ba6 100644
--- a/lib/bitset_stats.c
+++ b/lib/bitset_stats.c
@@ -576,11 +576,9 @@ bitset_stats_list (bitset bset, bitset_bindex *list,
   bitset_bindex tmp;
   bitset_bindex size;
   bitset_bindex i;
-  enum bitset_type type;

   count = BITSET_LIST_ (bset->s.bset, list, num, next);

-  type = BITSET_TYPE_ (bset->s.bset);
   BITSET_STATS_LISTS_INC (bset->s.bset);

   /* Log histogram of number of set bits.  */
diff --git a/lib/ebitset.c b/lib/ebitset.c
index 390dd0a..c8bcf42 100644
--- a/lib/ebitset.c
+++ b/lib/ebitset.c
@@ -1335,17 +1335,12 @@ ebitset_bytes (bitset_bindex n_bits ATTRIBUTE_UNUSED)
 bitset
 ebitset_init (bitset bset, bitset_bindex n_bits)
 {
-  bitset_windex size;
-
   bset->b.vtable = &ebitset_vtable;

   bset->b.csize = EBITSET_ELT_WORDS;

   EBITSET_ZERO_SET (bset);

-  size = n_bits ? (n_bits + EBITSET_ELT_BITS - 1) / EBITSET_ELT_BITS
-    : EBITSET_INITIAL_SIZE;
-
   EBITSET_ASIZE (bset) = 0;
   EBITSET_ELTS (bset) = 0;
   ebitset_resize (bset, n_bits);
diff --git a/lib/lbitset.c b/lib/lbitset.c
index 5922cd2..35854f2 100644
--- a/lib/lbitset.c
+++ b/lib/lbitset.c
@@ -936,17 +936,12 @@ lbitset_ones (bitset dst)
 static void
 lbitset_not (bitset dst, bitset src)
 {
-  lbitset_elt *elt;
   lbitset_elt *selt;
   lbitset_elt *delt;
   bitset_windex i;
   unsigned int j;
   bitset_windex windex;

-  /* This is another unfriendly operation for a linked list
-     bitset!  */
-  elt = LBITSET_TAIL (dst);
-
   windex = (BITSET_SIZE_ (dst) + BITSET_WORD_BITS - 1) / BITSET_WORD_BITS;

   for (i = 0; i < windex; i += LBITSET_ELT_WORDS)
--
1.7.8.2.334.gd4e886



reply via email to

[Prev in Thread] Current Thread [Next in Thread]