bug-bison
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: %destructor doesn't destruct what can be destructed by user actions


From: Joel E. Denny
Subject: Re: %destructor doesn't destruct what can be destructed by user actions
Date: Sat, 10 Mar 2007 16:05:38 -0500 (EST)

On Tue, 27 Feb 2007, Setzer, Sebastian (ext) wrote:

> The bison-manual (for example
> http://www.gnu.org/software/bison/manual/html_mono/bison.html) states:
> "Right-hand size symbols of a rule that explicitly triggers a syntax
> error via YYERROR are not discarded automatically. As a rule of thumb,
> destructors are invoked only when user actions cannot manage the
> memory."
> 
> Should be "Right-hand side..."?

Thanks.  I committed the following to fix that and some other typos.

> In the Calc++ - example, this user-action doesn't free the memory:
>     | "identifier"  { $$ = driver.variables[*$1]; }
> so this example will leak?

Thanks.  That's already fixed in CVS.

Index: ChangeLog
===================================================================
RCS file: /sources/bison/bison/ChangeLog,v
retrieving revision 1.1692
diff -p -u -r1.1692 ChangeLog
--- ChangeLog   9 Mar 2007 09:13:43 -0000       1.1692
+++ ChangeLog   10 Mar 2007 21:03:04 -0000
@@ -1,3 +1,10 @@
+2007-03-10  Joel E. Denny  <address@hidden>
+
+       * doc/bison.texinfo (Destructor Decl): Fix typo reported by Sebastian
+       Setzer.
+       (Java Differences): Fix some typos.
+       * THANKS: Add Sebastian Setzer.
+
 2007-03-07  Paolo Bonzini  <address@hidden>
 
         * data/java.m4 (b4_single_class_if): Remove.
Index: THANKS
===================================================================
RCS file: /sources/bison/bison/THANKS,v
retrieving revision 1.71
diff -p -u -r1.71 THANKS
--- THANKS      24 Feb 2007 05:43:35 -0000      1.71
+++ THANKS      10 Mar 2007 21:03:04 -0000
@@ -71,6 +71,7 @@ Richard Stallman          address@hidden
 Robert Anisko             address@hidden
 Satya Kiran Popuri        address@hidden
 S?bastien Fricker         address@hidden
+Sebastian Setzer          address@hidden
 Shura                     address@hidden
 Steve Murphy              address@hidden
 Tim Josling               address@hidden
Index: doc/bison.texinfo
===================================================================
RCS file: /sources/bison/bison/doc/bison.texinfo,v
retrieving revision 1.230
diff -p -u -r1.230 bison.texinfo
--- doc/bison.texinfo   9 Mar 2007 09:13:43 -0000       1.230
+++ doc/bison.texinfo   10 Mar 2007 21:03:08 -0000
@@ -4396,7 +4396,7 @@ The parser can @dfn{return immediately} 
 @code{YYABORT} or @code{YYACCEPT}, or failed error recovery, or memory
 exhaustion.
 
-Right-hand size symbols of a rule that explicitly triggers a syntax
+Right-hand side symbols of a rule that explicitly triggers a syntax
 error via @code{YYERROR} are not discarded automatically.  As a rule
 of thumb, destructors are invoked only when user actions cannot manage
 the memory.
@@ -8617,7 +8617,7 @@ The field's type can be changed using @s
 
 The different structure of the Java language forces several differences
 between C/C++ grammars, and grammars designed for Java parsers.  This
-section summarizes this differences.
+section summarizes these differences.
 
 @itemize
 @item
@@ -8650,7 +8650,7 @@ blocks, if specified, should include the
 scanner.  If there is no such block, the scanner can be any class
 that implements the appropriate interface (see @pxref{Java Scanner
 Interface}).
address@hidden item
address@hidden table
 
 Other @code{%code} blocks are not supported in Java parsers.
 The epilogue has the same meaning as in C/C++ code and it can

reply via email to

[Prev in Thread] Current Thread [Next in Thread]