bug-bison
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: %destructor feedback


From: Akim Demaille
Subject: Re: %destructor feedback
Date: Thu, 22 Dec 2005 09:45:18 +0100
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)

>>> "Joel" == Joel E Denny <address@hidden> writes:

 >> They were still badly formatted by the way :)

 > I'm clueless.

 > I just tried exporting the second patch from the email I received back 
 > through the mailing list.  I found that applying it perfectly reproduced 
 > my original code.  However, I see that the CVS copy has a number of tabs 
 > from my original code converted to spaces.  I'm guessing all of this also 
 > holds true for the first patch, but I haven't tried it.

 > Could it be something wrong on your end? Did anyone else have a problem 
 > this time?  If it's still me, does anyone have any clue what I could be 
 > doing wrong?

Actually maybe you sent things right, but I used the mailing archive,
and there, indeed there are no tabs, only spaces (but patch -l does
the trick).  A more painful issue is that (in the archive) some lines
are wrapped.  E.g., in

http://lists.gnu.org/archive/html/bison-patches/2005-12/msg00048.html

@@ -1902,19 +1912,16 @@ yyprocessOneStack (yyGLRStack* yystackp,
              break;
            }
          else
-           YYCHK (yyglrReduce (yystackp, yyk, -yyaction, 
yyfalse]b4_user_args[));
+           YYCHK (yyglrReduce (yystackp, yyk, -yyaction,
+                               yyfalse]b4_user_args[));
        }
     }
   return yyok;
 }





reply via email to

[Prev in Thread] Current Thread [Next in Thread]