Re: Bison 1.30h

[Akim Demaille]

| Hi,
| 
| In the srcs there are a few minor issues.
| 
| in files.c:
| const char *
| skeleton_find (...)
| needs serious attention. The use of const is violated here several
| ways. I didn't attempt to make any changes, and relied on the flexibility
| of C to survive this. Probably not a bug, but more care is needed for
| a clean compile. The patch allows it to compile without an error, only
| warnings.

I won't change bits in this area, as, anyway, we won't keep it.

| output.c needs a few casts to make a clean compile. Primarily the
| last parameter of output_short_or_char_table() or output_short_table().
| 
| Index: files.c
| ===================================================================
| RCS file: /home/cvsroot/Bison130g/src/files.c,v
| retrieving revision 1.1
| diff -r1.1 files.c
| 210c210
| < 
| ---
| >   const char *cp = getenv ("INIT");
| 224c224
| <       const char *cp = getenv ("INIT");
| ---
| > 
| Index: output.c
| ===================================================================
| RCS file: /home/cvsroot/Bison130g/src/output.c,v
| retrieving revision 1.1
| retrieving revision 1.2
| diff -r1.1 -r1.2
| 306c306
| <                           0, 1, max_user_token_number + 1);
| ---
| >                           0, 1, (short)(max_user_token_number + 1));
| 327c327
| <                     0, 1, nrules + 1);
| ---
| >                     0, 1, (short)(nrules + 1));
| 344c344
| <                     ritem[0], 1, yyrhs_size);
| ---
| >                     ritem[0], 1, (short)(yyrhs_size));
| 363c363
| <                   0, 1, nstates);
| ---
| >                   0, 1, (short) (nstates));
| 384c384
| <                     0, 1, nrules + 1);
| ---
| >                     0, 1, (short) (nrules + 1));
| 466c466
| <                       0, 1, ntokens + 1);
| ---
| >                       0, 1, (short)(ntokens + 1));
| 477c477
| <                     0, 1, nrules + 1);
| ---
| >                     0, 1, (short) (nrules + 1));
| 491c491
| <                   0, 1, nrules + 1);
| ---
| >                   0, 1, (short) (nrules + 1));
| 729c729
| <                   yydefact[0], 1, nstates);
| ---
| >                   yydefact[0], 1, (short) nstates);
| 838c838
| <                   yydefgoto[0], 1, nsyms - ntokens);
| ---
| >                   yydefgoto[0], 1, (short) (nsyms - ntokens));
| 1041c1041
| <                   base[0], 1, nstates);
| ---
| >                   base[0], 1, (short) nstates);
| 1046c1046
| <                   base[nstates], nstates + 1, nvectors);
| ---
| >                   base[nstates], (short) (nstates + 1), (short) nvectors);
| 1057c1057
| <                   table[0], 1, high + 1);
| ---
| >                   table[0], 1, (short) (high + 1));
| 1066c1066
| <                   check[0], 1, high + 1);
| ---
| >                   check[0], 1, (short) (high + 1));

Thanks!


What if you change the proto of output_table_blurp_with_bells so that
the parameters are int?