bug-bison
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: missing -lintl; expected conflicts


From: Akim Demaille
Subject: Re: missing -lintl; expected conflicts
Date: 22 Jan 2001 11:32:38 +0100
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Crater Lake)

| Akim Demaille wrote:
| > >>>>> "Frank" == Frank Heckenbach <address@hidden> writes:
| > 
| > Frank> What I actually meant to suggest (installed the current version
| > Frank> only to check it hadn't been done already) is the following:
| > 
| > Not a bad idea, but the patch is outdated.  Please, see
| > ftp://alpha.gnu.org/gnu/cvs/bison.tgz.
| 
| I hope this one is better:
| 
| --- bison/src/conflicts.c.orig        Wed Dec 20 21:01:17 2000
| +++ bison/src/conflicts.c     Fri Jan 19 06:54:47 2001
| @@ -423,6 +423,12 @@
|      sprintf (cp, _(" %d shift/reduce conflicts"), src_num);
|    cp += strlen (cp);
|  
| +  if (src_total > 0 && expected_conflicts > 0)
| +    {
| +      sprintf (cp, _(" (expected: %d)"), expected_conflicts);
| +      cp += strlen (cp);
| +    }
| +
|    if (src_num > 0 && rrc_num > 0)
|      sprintf (cp, _(" and"));
|    cp += strlen (cp);

Hi, I can't accept this patch since, unless I missed something, it
will write this sentence in each line of .output where conflicts are
reported.

/tmp % cat conflicts.y                                           nostromo 11:31
%token ID
%%
exp: exp '+' exp | exp '*' exp
   | ID
/tmp % LANG=C bis conflicts.y -v                                 nostromo 11:32
conflicts.y contains 4 shift/reduce conflicts.
/tmp % sed 3q conflicts.output                                   nostromo 11:32
State 5 contains 2 shift/reduce conflicts.
State 6 contains 2 shift/reduce conflicts.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]