[Bug binutils/27671] New: bfd/bfd-in.h, bfd/bfd-in2.h: Poisoning TRUE / FALSE also poisons e.g. Win32 system headers

[pexu at sourceware dot mail.kapsi.fi]

https://sourceware.org/bugzilla/show_bug.cgi?id=27671

            Bug ID: 27671
           Summary: bfd/bfd-in.h, bfd/bfd-in2.h: Poisoning TRUE / FALSE
                    also poisons e.g. Win32 system headers
           Product: binutils
           Version: 2.37 (HEAD)
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: binutils
          Assignee: unassigned at sourceware dot org
          Reporter: pexu at sourceware dot mail.kapsi.fi
  Target Milestone: ---

Created attachment 13337
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13337&action=edit
Do not poison TRUE and FALSE if _WIN32 is defined.

Hi.

As of commit ad9e24ad113a160d8d44dba0eb5cb02647a164e0 bfd_boolean, TRUE and
FALSE are now poisoned.

As TRUE and FALSE are widely used in e.g. Windows API headers, this change as
an undesired effect of (in this example case) of breaking Windows (MinGW)
targets.

I simply attempted to omit poisoning TRUE and FALSE if _WIN32 is defined, and
that did the trick.  Patch attached.  I do not know if this is the best
resolution, or if poisoning TRUE and FALSE shouldn't be done at all (i.e. are
there other targets that might use TRUE and FALSE in their system headers?)

-- 
You are receiving this mail because:
You are on the CC list for the bug.