[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug gold/19291] constant strings still don't always get relocated prope
From: |
cvs-commit at gcc dot gnu.org |
Subject: |
[Bug gold/19291] constant strings still don't always get relocated properly in a relocatable built with gold --script |
Date: |
Wed, 08 Nov 2017 23:14:34 +0000 |
https://sourceware.org/bugzilla/show_bug.cgi?id=19291
--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot
gnu.org> ---
The master branch has been updated by Cary Coutant <address@hidden>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=333d0055f6f162c334c36f1946b6fcdb5c92b681
commit 333d0055f6f162c334c36f1946b6fcdb5c92b681
Author: James Clarke <address@hidden>
Date: Wed Nov 8 15:13:53 2017 -0800
Fix problems with -r.
The fix committed for PR gold/19291 ended up breaking other cases. The
commit added adjustment code to write_local_symbols, but in many cases
compute_final_local_value_internal had already subtracted the output
section's address. To fix this, all other adjustments are now removed, so
only the one in write_local_symbols is left.
gold/
PR gold/22266
* object.cc (Sized_relobj_file::compute_final_local_value_internal):
Drop relocatable parameter and stop adjusting output value based on
it.
(Sized_relobj_file::compute_final_local_value): Stop passing
relocatable to compute_final_local_value_internal.
(Sized_relobj_file::do_finalize_local_symbols): Ditto.
* object.h (Sized_relobj_file::compute_final_local_value_internal):
Drop relocatable parameter.
--
You are receiving this mail because:
You are on the CC list for the bug.
- [Bug gold/19291] constant strings still don't always get relocated properly in a relocatable built with gold --script,
cvs-commit at gcc dot gnu.org <=