Re: [PATCH] Makefile: avoid undefined variables

[Mike Jonkmans]

On Thu, Oct 24, 2024 at 03:07:46PM -0400, Grisha Levit wrote:
> These are reported by make --warn-undefined-variables.
> 
> Most were being set previously (sometimes 20 years ago) and got left
> behind in recepies after their definitions have been removed. Others
> only get set in some configurations so it makes sense to prevent them
> from inheriting stray values from the environment otherwise. A few are
> just typos.

Good cleanup!
I see the Makefile has evolved in a good way.

... 
> Makefile.in
> - ALLOC_FILES,GLOBC,GLOBO,LIBRARY_SOURCE: remove deprecated variables

LIBRARY_SOURCE is useful to generate tags.

E.g.
LIBRARY_SOURCE = $(SHLIB_SOURCE) $(READLINE_SOURCE) $(HISTORY_SOURCE) \
                                $(TERMCAP_SOURCE) $(GLOB_SOURCE) 
$(TILDE_SOURCE) \
                                $(MALLOC_SOURCE)

This could vary with the chosen configure --with and --enable options.
Like --with-bash-malloc --with-curses, --with-installed-readline.

I am not sure if the research to do that is worth the trouble.
So the above 'fixed' version would be fine with me.

--
Regards, Mike