Re: Re: [PATCH v2 6/8] builtins/source: use source path in isolated mode

[Matheus Afonso Martins Moreira]

> I think we should restrict the search in
> BASH_SOURCE_PATH and shouldn't fall back to local files.

I concur but thought it'd be wise to discuss it first so I left it in.
Users might expect it to respect the configuration option.
I also saw that many of the PATH-like variable defaults
had the current directory in them. Finally, there is precedent
for this in other programming languages.

> Even if we intensionally fall back to local files, this part seems
> just a repetition of `search_for_file()'. I think this common part
> should be moved to `builtin_source()'.

I made it that way because it was explicitly requested
that the POSIX mode behavior not be affected in any way.
This way it's clear that there are two algorithms that the
function branches into and that they are completely
independent of each other. Should the current directory
searching logic be eliminated, the function will be simpler.

  -- Matheus