bash 5.0_p2 fails to compile with -DSYSLOG_HISTORY

[Tomas Mozes]

Configuration Information [Automatically generated, do not change]:
Machine: x86_64
OS: linux-gnu
Compiler: x86_64-pc-linux-gnu-gcc
Compilation CFLAGS: -mtune=native -O2 -pipe -frecord-gcc-switches
-Wno-parentheses -Wno-format-security
uname output: Linux hostname 4.19.18-gentoo #1 SMP PREEMPT Thu Jan 31
08:14:25 CET 2019 x86_64 Intel(R) Core(TM) i5-3570 CPU @ 3.40GHz
GenuineIntel GNU/Linux
Machine Type: x86_64-pc-linux-gnu

Bash Version: 5.0
Patch Level: 2
Release Status: release

Description:
In Gentoo Linux, we have a 'bashlogger' option to bash that basically
enabled '-DSYSLOG_HISTORY' during compilation. However, it doesn't work any
more with version 5.0_p2:

./mkbuiltins -D . getopts.def
x86_64-pc-linux-gnu-gcc -c   -DHAVE_CONFIG_H -DSHELL  -I. -I.. -I./include
-I.. -I../include -I../lib -I.
-DDEFAULT_PATH_VALUE='"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"'
-DSTANDARD_UTILS_PATH='"/bin:/usr/bin:/sbin:/usr/sbin"'
-DSYS_BASHRC='"/etc/bash/bashrc"'
-DSYS_BASH_LOGOUT='"/etc/bash/bash_logout"' -DNON_INTERACTIVE_LOGIN_SHELLS
-DSSH_SOURCE_BASHRC -DSYSLOG_HISTORY -mtune=native -O2 -pipe
-frecord-gcc-switches -Wno-parentheses -Wno-format-security getopts.c || (
rm -f getopts.c ; exit 1 )
rm -f getopts.c
rm -f shopt.o
./mkbuiltins -D . shopt.def
x86_64-pc-linux-gnu-gcc -c   -DHAVE_CONFIG_H -DSHELL  -I. -I.. -I./include
-I.. -I../include -I../lib -I.
-DDEFAULT_PATH_VALUE='"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"'
-DSTANDARD_UTILS_PATH='"/bin:/usr/bin:/sbin:/usr/sbin"'
-DSYS_BASHRC='"/etc/bash/bashrc"'
-DSYS_BASH_LOGOUT='"/etc/bash/bash_logout"' -DNON_INTERACTIVE_LOGIN_SHELLS
-DSSH_SOURCE_BASHRC -DSYSLOG_HISTORY -mtune=native -O2 -pipe
-frecord-gcc-switches -Wno-parentheses -Wno-format-security shopt.c || ( rm
-f shopt.c ; exit 1 )
./shopt.def: In function 'reset_shopt_options':
./shopt.def:373:3: error: 'syslog_history' undeclared (first use in this
function); did you mean 'save_history'?
   syslog_history = 1;
   ^~~~~~~~~~~~~~
   save_history
./shopt.def:373:3: note: each undeclared identifier is reported only once
for each function it appears in
make[1]: *** [Makefile:119: shopt.o] Error 1
make[1]: Leaving directory
'/var/tmp/portage/app-shells/bash-5.0_p2/work/bash-5.0/builtins'
make: *** [Makefile:733: builtins/libbuiltins.a] Error 1

If we replace '-DSYSLOG_HISTORY' with '-DSYSLOG_HISTORY -DSYSLOG_SHOPT' it
works fine. However, we are not sure whether this is a regression or not.
Please give us advice whether this should be fixed on bash side or on the
Gentoo side by adding '-DSYSLOG_SHOPT'.

Repeat-By:
tar xvf bash-5.0.tar.gz
cd bash-5.0
export CFLAGS+=" -DSYSLOG_HISTORY"
./configure --enable-history
make

...
./mkbuiltins -D . shopt.def
gcc -c   -DHAVE_CONFIG_H -DSHELL  -I. -I..  -I.. -I../include -I../lib
-I.    -DSYSLOG_HISTORY -Wno-parentheses -Wno-format-security shopt.c || (
rm -f shopt.c ; exit 1 )
./shopt.def: In function 'reset_shopt_options':
./shopt.def:373:3: error: 'syslog_history' undeclared (first use in this
function); did you mean 'save_history'?
   syslog_history = 1;
   ^~~~~~~~~~~~~~
   save_history
./shopt.def:373:3: note: each undeclared identifier is reported only once
for each function it appears in
make[1]: *** [Makefile:119: shopt.o] Error 1
make[1]: Leaving directory '/tmp/bash/bash-5.0/builtins'
make: *** [Makefile:733: builtins/libbuiltins.a] Error 1