Re: [PATCH] build: fix build without MALLOC_STATS

[Chet Ramey]

On 4/17/15 10:47 AM, Eric Blake wrote:
> gcc -L./builtins -L./lib/readline -L./lib/readline -L./lib/glob -L./lib/tilde 
> -L./lib/malloc -L./lib/sh  -rdynamic  -g -O2 -Wno-parentheses 
> -Wno-format-security -o bash shell.o eval.o y.tab.o general.o make_cmd.o 
> print_cmd.o  dispose_cmd.o execute_cmd.o variables.o copy_cmd.o error.o 
> expr.o flags.o jobs.o subst.o hashcmd.o hashlib.o mailcheck.o trap.o input.o 
> unwind_prot.o pathexp.o sig.o test.o version.o alias.o array.o arrayfunc.o 
> assoc.o braces.o bracecomp.o bashhist.o bashline.o  list.o stringlib.o 
> locale.o findcmd.o redir.o pcomplete.o pcomplib.o syntax.o xmalloc.o  
> -lbuiltins -lglob -lsh -lreadline -lhistory -ltermcap -ltilde -lmalloc    -ldl
> shell.o: In function `sh_exit':
> /home/eblake/bash/shell.c:968: undefined reference to `trace_malloc_stats'
> 
> * shell.c (sh_exit): Require MALLOC_STATS, not just MALLOC_DEBUG.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> 
> Another fix that I need to get the devel branch of bash.git to compile
> (I'm not sure what logic you intended for MALLOC_DEBUG vs.
> MALLOC_STATS, nor if one should imply the other, so I'm okay if your
> patch is different than my temporary workaround).

Look at lib/malloc/imalloc.h, where MALLOC_DEBUG implies MALLOC_STATS.

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU    chet@case.edu    http://cnswww.cns.cwru.edu/~chet/