[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='.
From: |
Ralf Wildenhues |
Subject: |
bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='. |
Date: |
Sun, 7 Nov 2010 14:26:09 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hello Stefano, Andy,
* Stefano Lattarini wrote on Sat, Nov 06, 2010 at 06:10:44PM CET:
> On Friday 05 November 2010, Stefano Lattarini wrote:
> > I can confirm the bug with latest automake (from git master), with
> > a much-reduced minimal testcase (see attachment).
> >
> > I still haven't looked for an explanation or a fix, though.
> I've manged to find a very simple fix for the bug (see attached patch).
>
> OK to apply to maint?
OK if it passes the whole testsuite.
Thanks to both of you, for the report and the fast fix!
Cheers,
Ralf
> From b8de299295e081909c6d0a8a1cef957b337e3732 Mon Sep 17 00:00:00 2001
> From: Stefano Lattarini <address@hidden>
> Date: Sat, 6 Nov 2010 12:46:52 +0100
> Subject: [PATCH] Fix a bug in variable concatanation with `+='.
>
> * lib/Automake/VarDef.pm (append): Remove extra backslash-escaped
> newlines from the end of the variable's content, before appending
> to it.
> * tests/pluseq11.test: New test, exposing the bug.
> * tests/Makefile.am (TESTS): Update.
>
> Reported by Andy Wingo.
- bug#7333: bug concatenating CLEANFILES in automake 1.11, Andy Wingo, 2010/11/05
- bug#7333: bug concatenating CLEANFILES in automake 1.11, Stefano Lattarini, 2010/11/05
- bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='. (was: Re: bug#7333: bug concatenating CLEANFILES in automake 1.11), Stefano Lattarini, 2010/11/06
- bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='.,
Ralf Wildenhues <=
- bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='., Stefano Lattarini, 2010/11/07
- bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='., Ralf Wildenhues, 2010/11/08
- bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='., Glenn Morris, 2010/11/09
- bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='., Ralf Wildenhues, 2010/11/10
- bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='., Glenn Morris, 2010/11/10
- bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='., Glenn Morris, 2010/11/10
- bug#7333: [PATCH] {maint} Fix a bug in variable concatanation with `+='., Ralf Wildenhues, 2010/11/10