Re: [PATCH] Should use backslashes in depend2.am

[Jan Engelhardt]

On Oct 21 2007 21:01, Ralf Wildenhues wrote:
>* Jan Engelhardt wrote on Sun, Oct 21, 2007 at 08:53:40PM CEST:
>> 
>> ---
>>  lib/am/depend2.am |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> Index: automake-1.10/lib/am/depend2.am
>> ===================================================================
>> --- automake-1.10.orig/lib/am/depend2.am
>> +++ automake-1.10/lib/am/depend2.am
>> @@ -66,7 +66,7 @@ if %FASTDEP%
>>  ## In fast-dep mode, we can always use -o.
>>  ## For non-suffix rules, we must emulate a VPATH search on %SOURCE%.
>>  ?!GENERIC?  %COMPILE% -MT %OBJ% -MD -MP -MF %DEPBASE%.Tpo %-c% -o %OBJ% 
>> `test -f '%SOURCE%' || echo '$(srcdir)/'`%SOURCE%
>> -?GENERIC??!SUBDIROBJ?       %COMPILE% -MT %OBJ% -MD -MP -MF %DEPBASE%.Tpo 
>> %-c% -o %OBJ% %SOURCE%
>> +?GENERIC??!SUBDIROBJ?       %COMPILE% -MT %OBJ% -MD -MP -MF %DEPBASE%.Tpo 
>> %-c% -o %OBJ% %SOURCE% && \
>>  ?GENERIC??SUBDIROBJ?        depbase=`echo %OBJ% | sed 
>> 's|[^/]*$$|$(DEPDIR)/&|;s|\.o$$||'`;\
>>  ?GENERIC??SUBDIROBJ?        %COMPILE% -MT %OBJ% -MD -MP -MF %DEPBASE%.Tpo 
>> %-c% -o %OBJ% %SOURCE% &&\
>>      mv -f %DEPBASE%.Tpo %DEPBASE%.Po
>[...]
>
>Thanks for the patch.  Could you please show what it is supposed to fix?
>

My "don't be so verbose" patch (now posix compliant as it seems to
have turned out) - where the full command needs to be (read: should
be, preferably, but not striclty necessary) on one line, as @echo is
used.

Since ?SUBDIROBJ? uses &&\ I thought it would not hurt too much to also
use it in the ?!SUBDIROBJ? case.