Re: [WIP PATCH for Dlang support] d: token constructors

[Adela Vais]

Hello Akim,

I attached the patches and took into account the comment underlining (I did
not notice the style until you pointed it out, sorry about that).
Thank you for your patience and help!

Adela

În sâm., 30 ian. 2021 la 09:49, Akim Demaille <akim.demaille@gmail.com> a
scris:

> Hi Adela,
>
> > Le 29 janv. 2021 à 15:43, Adela Vais <adela.vais99@gmail.com> a écrit :
> >
> > Hello Akim,
> >
> > I made the token constructors work. Doing this, I realized that the
> Symbol
> > constructors needed some changes, which I did in D.
> > After our discussion from Tuesday, I do agree that it's not the best
> > approach.
> > The code is quite unnecessarily complex, so I will rewrite the
> constructors
> > to be generated with M4, to be easier to maintain.
> >
> > Now, the problem is that token constructors need the new version of the
> > Symbol constructors to be working correctly.
> > So it's your choice if you decide to install it like this or wait until I
> > rewrite the constructors.
>
> I'm installing the first of your patches, which fixes style issues.
> Please, be sure to make commit messages that fit with 76 columns.
> And when it applies, describe the changes in the files within the
> file section.  So I rewrote your first commit message as follows:
>
> Author: Adela Vais <adela.vais99@gmail.com>
> Date:   Mon Jan 25 17:59:06 2021 +0200
>
>     d: tests: various style fixes
>
>     * tests/calc.at, tests/scanner.at: Here.
>     (yylex): Report values directly, without storing them to the union
>     first.
>
> instead of
>
>     d: tests: various style fixes
>
>     Now the tests report values in yylex() directly, without storing them
> to the union first.
>
>     * tests/calc.at, tests/scanner.at: Here.
>
>
> Let's wait for the version with m4, to keep a simple history in
> the repository.  No hurry, 3.8 is not ready...
>
> But please, even though it's unpleasant and LITS, keep the comments
> correctly underlined:
>
>
> +# _b4_constructor_maker_define_types(SYMBOL-NUM)
> +# ----------------------------------
> +# Declare the case branches in the Symbol constructor for SYMBOL-NUM
> values.
>
>
> +# AT_YYLEX_RETURN_VAL
> +# ---------------
> +m4_define([AT_YYLEX_RETURN_VAL],
>
> etc.
>
> Cheers!

0003-d-add-token-constructors-support.patch
Description: Source code patch

0001-d-rewrite-Symbol-s-constructors-in-M4.patch
Description: Source code patch

0002-d-add-api.value.type-union-support.patch
Description: Source code patch