bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] cex: fix leaks


From: Akim Demaille
Subject: Re: [PATCH] cex: fix leaks
Date: Mon, 18 May 2020 20:10:22 +0200

Hi Vincent!

> Le 18 mai 2020 à 14:23, address@hidden a écrit :
> 
> 
> Hey Akim,
> 
>> I think we should at least use typedef to clarify what different types of 
>> list exist (e.g., parse_state_list_t).
> I like this idea a lot.

Good, let's go for it.  I won't do that now, but many tomorrow in the morning.

> I also think changing the hash maps to bitset vectors is fine; I initially 
> didn’t want to since I knew they could be pretty sparse.

Then, instead of a bitsetv, a table of malloced bitsets should do it.  It might 
be sparse, but on a quite compact range, isn't it?

> I’ll look at the leak tonight. I have an idea where one should be coming from 
> but I didn’t really get the chance to look yesterday. 

No worries, you already did wonders :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]