[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] c++: improvements on symbol kinds
From: |
Hans Åberg |
Subject: |
Re: [PATCH 3/5] c++: improvements on symbol kinds |
Date: |
Tue, 14 Apr 2020 22:27:50 +0200 |
> On 11 Apr 2020, at 08:47, Akim Demaille <address@hidden> wrote:
>
> Instead of
>
> /// (Internal) symbol kind.
> enum symbol_kind_type
> {
> YYNTOKENS = 5, ///< Number of tokens.
...
> generate
>
> /// Symbol kinds.
> struct symbol_kind
> {
> enum symbol_kind_type
> {
> YYNTOKENS = 5, ///< Number of tokens.
...
I use symbol table lookups of the form:
std::optional<std::pair<my::the_parser::token_type, my::value>> x =
mli::symbol_table.find(yylval.text);
What will the new name be?
The most logical from the user point of view would be to have
the_parser::symbol_type.
- [PATCH 0/5] Clean up, Akim Demaille, 2020/04/11
- [PATCH 2/5] d: improvements on symbol kinds, Akim Demaille, 2020/04/11
- [PATCH 1/5] symbols: minor fixes, Akim Demaille, 2020/04/11
- [PATCH 4/5] todo: update, Akim Demaille, 2020/04/11
- [PATCH 3/5] c++: improvements on symbol kinds, Akim Demaille, 2020/04/11
- Re: [PATCH 3/5] c++: improvements on symbol kinds,
Hans Åberg <=
- Re: [PATCH 3/5] c++: improvements on symbol kinds, Akim Demaille, 2020/04/15
- Re: [PATCH 3/5] c++: improvements on symbol kinds, Hans Åberg, 2020/04/15
- Re: [PATCH 3/5] c++: improvements on symbol kinds, Akim Demaille, 2020/04/15
- Re: [PATCH 3/5] c++: improvements on symbol kinds, Hans Åberg, 2020/04/15
- Re: [PATCH 3/5] c++: improvements on symbol kinds, Akim Demaille, 2020/04/15
- Re: [PATCH 3/5] c++: improvements on symbol kinds, Hans Åberg, 2020/04/15
- Re: [PATCH 3/5] c++: improvements on symbol kinds, Akim Demaille, 2020/04/16
- Re: [PATCH 3/5] c++: improvements on symbol kinds, Hans Åberg, 2020/04/16
[PATCH 5/5] style: rename YYNOMEM as YYENOMEM, Akim Demaille, 2020/04/11