bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Build segfault bison 3.4


From: Akim Demaille
Subject: Re: Build segfault bison 3.4
Date: Sun, 19 May 2019 18:17:23 +0200


> Le 19 mai 2019 à 14:30, neok m4700 <address@hidden> a écrit :
> 
> Hi,
> 
> I've opened a pull request to correct a build segfault on bison's latest
> release.
> 
> Please comment on https://github.com/akimd/bison/pull/11

Bummer...  Where were you during the prerelease phase???

I'll install this instead.  Thanks a lot for the report!

commit c8e57e81594dd9d8333e221fe64cf00e82213b30
Author: Akim Demaille <address@hidden>
Date:   Sun May 19 18:14:21 2019 +0200

    diagnostics: don't crash when libtextstyle is installed
    
    Reported by neok m4700.
    https://lists.gnu.org/archive/html/bison-patches/2019-05/msg00025.html
    https://github.com/akimd/bison/pull/11
    
    * src/complain.c (complain_init_color): style_file_prepare _needs_ a
    string as second argument.

diff --git a/THANKS b/THANKS
index 50b33f48d..07355b23 100644
--- a/THANKS
+++ b/THANKS
@@ -118,6 +118,7 @@ Mike Sullivan             address@hidden
 Nate Guerin               address@hidden
 Neil Booth                address@hidden
 Nelson H. F. Beebe        address@hidden
+neok m4700                address@hidden
 Nick Bowler               address@hidden
 Nicolas Bedon             address@hidden
 Nicolas Burrus            address@hidden
diff --git a/src/complain.c b/src/complain.c
index cd5ee19c..19c03cc3 100644
--- a/src/complain.c
+++ b/src/complain.c
@@ -255,7 +255,7 @@ complain_init_color (void)
       || color_mode == color_html
       || (color_mode == color_tty && isatty (STDERR_FILENO)))
     {
-      style_file_prepare ("BISON_STYLE", NULL, pkgdatadir (),
+      style_file_prepare ("BISON_STYLE", "BISON_STYLEDIR", pkgdatadir (),
                           "bison-default.css");
       /* As a fallback, use the default in the current directory.  */
       struct stat statbuf;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]