Re: [PATCH 1/2] symbols: improve symbol aliasing

[Akim Demaille]

Le 30 juil. 2013 à 18:41, Valentin Tolmer <address@hidden> a écrit :

>> 
>> Don't you think that these guys should still work on symbols
>> as before, but process their content behind the scenes?
>> 
>> I think that these changes should be mostly internal, and
>> virtualy invisible from the call sites.
>> 
> I thought so, too, but apart from somewhat simplifying the code, it seemed to 
> make more sense to call the function on the content, as this is what we want 
> to modify.

I think that the caller does not need to know what she
is modifying.  She basically wants to change information
about the symbols, and how symbols are implemented is not
her business.  Unfortunately, because we don't provide
accessors, eventually the implementation shows, when reading
these fields; but in C++ for instance, we would have hidden
this.

> But if you think it's better to make the changes transparent, I understand, 
> and will revert.

I think it is better to hide this, yes.