>From 27c4af044d63d26f8622f5cd6bc8da1d2a4bd9f4 Mon Sep 17 00:00:00 2001 From: Valentin Tolmer Date: Wed, 30 Jan 2013 11:30:15 +0100 Subject: [PATCH] warnings: introduce -Wprecedence The new warning category precedence is used for useless precedence and associativity reporting. * src/complain.c, src/complain.h, src/getargs.c: Introduce precedence warning category. -Wprecedence can now be used, but is disabled by default. Precedence category regroups the useless precedence and associativity warnings. * doc/bison.texi: Document the warnings and provide an example. * tests/conflicts.at tests/existing.at tests/local.at tests/regression.at: Adapt testsuite for the new category (-Wprecedence instead of -Wother for these warnings). --- NEWS | 45 +++++++-- doc/bison.texi | 18 ++++ src/complain.c | 1 + src/complain.h | 4 +- src/getargs.c | 3 + src/symtab.c | 4 +- tests/conflicts.at | 68 +++++++------- tests/existing.at | 258 +++++++++++++++++++++++++-------------------------- tests/local.at | 2 +- tests/regression.at | 10 +- 10 files changed, 234 insertions(+), 179 deletions(-) diff --git a/NEWS b/NEWS index 62f834b..57d6d26 100644 --- a/NEWS +++ b/NEWS @@ -198,13 +198,6 @@ GNU Bison NEWS bar.y: error: shift/reduce conflicts: 1 found, 0 expected bar.y: error: reduce/reduce conflicts: 2 found, 0 expected -*** Useless precedence - - Bison now warns about symbols with a declared precedence but no declared - associativity (i.e. declared with %precedence), and whose precedence is - never used. In that case, the symbol can be safely declared with %token - instead, without modifying the parsing tables. - ** Additional yylex/yyparse arguments The new directive %param declares additional arguments to both yylex and @@ -303,6 +296,44 @@ GNU Bison NEWS when declaring associativity at the same time, with %left (or %right, %precedence, %nonassoc), B was inferior to A. +** Useless precedence and associativity + +*** Precedence warning category + + A new category of warning, precedence (-Wprecedence) has been introduced, and + is used for the useless precedence and associativity warnings. + +*** Useless associativity + + Bison now warns about symbols with a declared associativity that is never + used to resolve conflicts. In that case, using %precedence is sufficient. + Solving these warnings may raise useless precedence warnings, as the symbols + no longer have associativity. For example : + + %nonassoc '=' + %% + e: VAR '=' NUM; + + will produce a + + warning: useless associativity for '=' [-Wprecedence] + + +*** Useless precedence + + Bison now warns about symbols with a declared precedence but no declared + associativity (i.e. declared with %precedence), and whose precedence is + never used. In that case, the symbol can be safely declared with %token + instead, without modifying the parsing tables. For example : + + %precedence '=' + %% + e: VAR '=' NUM; + + will produce a + + warning: useless precedence for '=' [-Wprecedence] + * Noteworthy changes in release 2.7 (2012-12-12) [stable] ** Bug fixes diff --git a/doc/bison.texi b/doc/bison.texi index d2d3da3..39f2636 100644 --- a/doc/bison.texi +++ b/doc/bison.texi @@ -9716,6 +9716,24 @@ no effect on the conflict report. Deprecated constructs whose support will be removed in future versions of Bison. address@hidden precedence +Useless precedence and associativity. Bison detects whether defined precedence +and associativity are uselful, and warns if not. For example, in the grammar +below, Bison warns about useless associativity for @samp{=}: + address@hidden +%nonassoc '=' +%% +assign: VAR '=' NUM; address@hidden example + +In this case, two @samp{=} in a row will be detected as a syntax error even without address@hidden (there are no rule allowing that case), so the associativity is +useless, and can be replaced by @code{%precedence}. Bison then warns about useless +precedence, because @samp{=} can be safely declared as a @code{%token} (there are no +conflicts involving @samp{=} solved with precedence comparison). This warning is +disabled by default. + @item other All warnings not categorized above. These warnings are enabled by default. diff --git a/src/complain.c b/src/complain.c index d43e623..c6e03d5 100644 --- a/src/complain.c +++ b/src/complain.c @@ -50,6 +50,7 @@ warnings_print_categories (warnings warn_flags) "conflicts-sr", "conflicts-rr", "deprecated", + "precedence", "other" }; diff --git a/src/complain.h b/src/complain.h index 9404388..0110c6b 100644 --- a/src/complain.h +++ b/src/complain.h @@ -36,7 +36,9 @@ typedef enum Wconflicts_sr = 1 << 2, /**< S/R conflicts. */ Wconflicts_rr = 1 << 3, /**< R/R conflicts. */ Wdeprecated = 1 << 4, /**< Obsolete constructs. */ - Wother = 1 << 5, /**< All other warnings. */ + Wprecedence = 1 << 5, /**< Useless precedence and associativity. */ + + Wother = 1 << 6, /**< All other warnings. */ Werror = 1 << 10, /** This bit is no longer used. */ diff --git a/src/getargs.c b/src/getargs.c index f6d61c3..97191ef 100644 --- a/src/getargs.c +++ b/src/getargs.c @@ -252,6 +252,7 @@ static const char * const warnings_args[] = "conflicts-sr - S/R conflicts", "conflicts-rr - R/R conflicts", "deprecated - obsolete constructs", + "precedence - useless precedence and associativity", "other - all other warnings", "all - all of the above", "error - warnings are errors", @@ -266,6 +267,7 @@ static const int warnings_types[] = Wconflicts_sr, Wconflicts_rr, Wdeprecated, + Wprecedence, Wother, Wall, Werror @@ -381,6 +383,7 @@ Warning categories include:\n\ `conflicts-sr' S/R conflicts (enabled by default)\n\ `conflicts-rr' R/R conflicts (enabled by default)\n\ `deprecated' obsolete constructs\n\ + `precedence' useless precedence and associativity\n\ `other' all other warnings (enabled by default)\n\ `all' all the warnings\n\ `no-CATEGORY' turn off warnings in CATEGORY\n\ diff --git a/src/symtab.c b/src/symtab.c index e48c11e..62b1c2d 100644 --- a/src/symtab.c +++ b/src/symtab.c @@ -1075,7 +1075,7 @@ print_precedence_warnings (void) && !prec_nodes[i]->pred && !prec_nodes[i]->succ && s->assoc == precedence_assoc) - complain (&s->location, Wother, + complain (&s->location, Wprecedence, _("useless precedence for %s"), s->tag); } } @@ -1133,7 +1133,7 @@ print_assoc_warnings (void) { symbol *s = symbols[i]; if (is_assoc_useless (s)) - complain (&s->location, Wother, + complain (&s->location, Wprecedence, _("useless associativity for %s"), s->tag); } } diff --git a/tests/conflicts.at b/tests/conflicts.at index 92e4ae8..9db52cf 100644 --- a/tests/conflicts.at +++ b/tests/conflicts.at @@ -39,12 +39,12 @@ e: T A T ; ]]) -AT_BISON_CHECK([input.y], 0, [], -[[input.y:5.13: warning: useless precedence for E [-Wother] -input.y:2.7: warning: useless associativity for A [-Wother] -input.y:2.9: warning: useless associativity for B [-Wother] -input.y:3.8: warning: useless associativity for C [-Wother] -input.y:4.11: warning: useless associativity for D [-Wother] +AT_BISON_CHECK([-Wprecedence input.y], 0, [], +[[input.y:5.13: warning: useless precedence for E [-Wprecedence] +input.y:2.7: warning: useless associativity for A [-Wprecedence] +input.y:2.9: warning: useless associativity for B [-Wprecedence] +input.y:3.8: warning: useless associativity for C [-Wprecedence] +input.y:4.11: warning: useless associativity for D [-Wprecedence] ]]) AT_CLEANUP @@ -110,26 +110,26 @@ int main (void) } ]]) -AT_BISON_CHECK([-o input.c input.y], [], [], -[[input.y:24.13: warning: useless precedence for R [-Wother] -input.y:24.15: warning: useless precedence for S [-Wother] -input.y:24.17: warning: useless precedence for T [-Wother] -input.y:24.19: warning: useless precedence for U [-Wother] -input.y:25.13: warning: useless precedence for V [-Wother] -input.y:25.15: warning: useless precedence for W [-Wother] -input.y:18.8: warning: useless associativity for E [-Wother] -input.y:18.10: warning: useless associativity for F [-Wother] -input.y:18.12: warning: useless associativity for G [-Wother] -input.y:19.8: warning: useless associativity for H [-Wother] -input.y:19.10: warning: useless associativity for I [-Wother] -input.y:20.8: warning: useless associativity for J [-Wother] -input.y:21.8: warning: useless associativity for K [-Wother] -input.y:22.8: warning: useless associativity for L [-Wother] -input.y:22.10: warning: useless associativity for M [-Wother] -input.y:22.12: warning: useless associativity for N [-Wother] -input.y:23.11: warning: useless associativity for O [-Wother] -input.y:23.13: warning: useless associativity for P [-Wother] -input.y:23.15: warning: useless associativity for Q [-Wother] +AT_BISON_CHECK([-Wprecedence -o input.c input.y], [], [], +[[input.y:24.13: warning: useless precedence for R [-Wprecedence] +input.y:24.15: warning: useless precedence for S [-Wprecedence] +input.y:24.17: warning: useless precedence for T [-Wprecedence] +input.y:24.19: warning: useless precedence for U [-Wprecedence] +input.y:25.13: warning: useless precedence for V [-Wprecedence] +input.y:25.15: warning: useless precedence for W [-Wprecedence] +input.y:18.8: warning: useless associativity for E [-Wprecedence] +input.y:18.10: warning: useless associativity for F [-Wprecedence] +input.y:18.12: warning: useless associativity for G [-Wprecedence] +input.y:19.8: warning: useless associativity for H [-Wprecedence] +input.y:19.10: warning: useless associativity for I [-Wprecedence] +input.y:20.8: warning: useless associativity for J [-Wprecedence] +input.y:21.8: warning: useless associativity for K [-Wprecedence] +input.y:22.8: warning: useless associativity for L [-Wprecedence] +input.y:22.10: warning: useless associativity for M [-Wprecedence] +input.y:22.12: warning: useless associativity for N [-Wprecedence] +input.y:23.11: warning: useless associativity for O [-Wprecedence] +input.y:23.13: warning: useless associativity for P [-Wprecedence] +input.y:23.15: warning: useless associativity for Q [-Wprecedence] ]]) AT_COMPILE([input]) @@ -174,17 +174,17 @@ f: B ; ]]) -AT_BISON_CHECK([-fcaret -o input.c input.y], 0, [], -[[input.y:2.13: warning: useless precedence for Z [-Wother] +AT_BISON_CHECK([-Wprecedence -fcaret -o input.c input.y], 0, [], +[[input.y:2.13: warning: useless precedence for Z [-Wprecedence] %precedence Z ^ -input.y:5.7: warning: useless associativity for W [-Wother] +input.y:5.7: warning: useless associativity for W [-Wprecedence] %left W ^ -input.y:6.8: warning: useless associativity for V [-Wother] +input.y:6.8: warning: useless associativity for V [-Wprecedence] %right V ^ -input.y:7.11: warning: useless associativity for U [-Wother] +input.y:7.11: warning: useless associativity for U [-Wprecedence] %nonassoc U ^ ]]) @@ -1196,10 +1196,10 @@ e: e '+' e ; ]]) -AT_BISON_CHECK([-o input.c input.y], 0, [], +AT_BISON_CHECK([-Wall -o input.c input.y], 0, [], [[input.y: warning: 4 shift/reduce conflicts [-Wconflicts-sr] -input.y:1.7-9: warning: useless associativity for '+' [-Wother] -input.y:2.7-9: warning: useless associativity for '*' [-Wother] +input.y:1.7-9: warning: useless associativity for '+' [-Wprecedence] +input.y:2.7-9: warning: useless associativity for '*' [-Wprecedence] ]]) AT_CLEANUP diff --git a/tests/existing.at b/tests/existing.at index 6118e7d..34f088b 100644 --- a/tests/existing.at +++ b/tests/existing.at @@ -428,43 +428,43 @@ dnl don't like even `print $!4;'. dnl BISON-STDERR [AT_COND_CASE([[canonical LR]], [[input.y: warning: 265 shift/reduce conflicts [-Wconflicts-sr] -input.y:19.8-16: warning: useless associativity for FUNC_CALL [-Wother] -input.y:21.8-14: warning: useless associativity for YNUMBER [-Wother] -input.y:21.16-22: warning: useless associativity for YSTRING [-Wother] -input.y:22.14-22: warning: useless associativity for APPEND_OP [-Wother] -input.y:23.8-15: warning: useless associativity for ASSIGNOP [-Wother] -input.y:23.33-41: warning: useless associativity for CONCAT_OP [-Wother] -input.y:27.8-18: warning: useless associativity for LEX_GETLINE [-Wother] -input.y:28.8-13: warning: useless associativity for LEX_IN [-Wother] -input.y:29.23-31: warning: useless associativity for INCREMENT [-Wother] -input.y:29.33-41: warning: useless associativity for DECREMENT [-Wother] -input.y:30.8-18: warning: useless associativity for LEX_BUILTIN [-Wother] -input.y:30.20-29: warning: useless associativity for LEX_LENGTH [-Wother] -input.y:40.11-13: warning: useless associativity for ',' [-Wother] -input.y:47.8-10: warning: useless associativity for '!' [-Wother] -input.y:47.12-16: warning: useless associativity for UNARY [-Wother] -input.y:50.7-9: warning: useless associativity for '$' [-Wother] -input.y:51.7-9: warning: useless associativity for '(' [-Wother] -input.y:51.11-13: warning: useless associativity for ')' [-Wother]]], +input.y:19.8-16: warning: useless associativity for FUNC_CALL [-Wprecedence] +input.y:21.8-14: warning: useless associativity for YNUMBER [-Wprecedence] +input.y:21.16-22: warning: useless associativity for YSTRING [-Wprecedence] +input.y:22.14-22: warning: useless associativity for APPEND_OP [-Wprecedence] +input.y:23.8-15: warning: useless associativity for ASSIGNOP [-Wprecedence] +input.y:23.33-41: warning: useless associativity for CONCAT_OP [-Wprecedence] +input.y:27.8-18: warning: useless associativity for LEX_GETLINE [-Wprecedence] +input.y:28.8-13: warning: useless associativity for LEX_IN [-Wprecedence] +input.y:29.23-31: warning: useless associativity for INCREMENT [-Wprecedence] +input.y:29.33-41: warning: useless associativity for DECREMENT [-Wprecedence] +input.y:30.8-18: warning: useless associativity for LEX_BUILTIN [-Wprecedence] +input.y:30.20-29: warning: useless associativity for LEX_LENGTH [-Wprecedence] +input.y:40.11-13: warning: useless associativity for ',' [-Wprecedence] +input.y:47.8-10: warning: useless associativity for '!' [-Wprecedence] +input.y:47.12-16: warning: useless associativity for UNARY [-Wprecedence] +input.y:50.7-9: warning: useless associativity for '$' [-Wprecedence] +input.y:51.7-9: warning: useless associativity for '(' [-Wprecedence] +input.y:51.11-13: warning: useless associativity for ')' [-Wprecedence]]], [[input.y: warning: 65 shift/reduce conflicts [-Wconflicts-sr] -input.y:19.8-16: warning: useless associativity for FUNC_CALL [-Wother] -input.y:21.8-14: warning: useless associativity for YNUMBER [-Wother] -input.y:21.16-22: warning: useless associativity for YSTRING [-Wother] -input.y:22.14-22: warning: useless associativity for APPEND_OP [-Wother] -input.y:23.8-15: warning: useless associativity for ASSIGNOP [-Wother] -input.y:23.33-41: warning: useless associativity for CONCAT_OP [-Wother] -input.y:27.8-18: warning: useless associativity for LEX_GETLINE [-Wother] -input.y:28.8-13: warning: useless associativity for LEX_IN [-Wother] -input.y:29.23-31: warning: useless associativity for INCREMENT [-Wother] -input.y:29.33-41: warning: useless associativity for DECREMENT [-Wother] -input.y:30.8-18: warning: useless associativity for LEX_BUILTIN [-Wother] -input.y:30.20-29: warning: useless associativity for LEX_LENGTH [-Wother] -input.y:40.11-13: warning: useless associativity for ',' [-Wother] -input.y:47.8-10: warning: useless associativity for '!' [-Wother] -input.y:47.12-16: warning: useless associativity for UNARY [-Wother] -input.y:50.7-9: warning: useless associativity for '$' [-Wother] -input.y:51.7-9: warning: useless associativity for '(' [-Wother] -input.y:51.11-13: warning: useless associativity for ')' [-Wother]]])[ +input.y:19.8-16: warning: useless associativity for FUNC_CALL [-Wprecedence] +input.y:21.8-14: warning: useless associativity for YNUMBER [-Wprecedence] +input.y:21.16-22: warning: useless associativity for YSTRING [-Wprecedence] +input.y:22.14-22: warning: useless associativity for APPEND_OP [-Wprecedence] +input.y:23.8-15: warning: useless associativity for ASSIGNOP [-Wprecedence] +input.y:23.33-41: warning: useless associativity for CONCAT_OP [-Wprecedence] +input.y:27.8-18: warning: useless associativity for LEX_GETLINE [-Wprecedence] +input.y:28.8-13: warning: useless associativity for LEX_IN [-Wprecedence] +input.y:29.23-31: warning: useless associativity for INCREMENT [-Wprecedence] +input.y:29.33-41: warning: useless associativity for DECREMENT [-Wprecedence] +input.y:30.8-18: warning: useless associativity for LEX_BUILTIN [-Wprecedence] +input.y:30.20-29: warning: useless associativity for LEX_LENGTH [-Wprecedence] +input.y:40.11-13: warning: useless associativity for ',' [-Wprecedence] +input.y:47.8-10: warning: useless associativity for '!' [-Wprecedence] +input.y:47.12-16: warning: useless associativity for UNARY [-Wprecedence] +input.y:50.7-9: warning: useless associativity for '$' [-Wprecedence] +input.y:51.7-9: warning: useless associativity for '(' [-Wprecedence] +input.y:51.11-13: warning: useless associativity for ')' [-Wprecedence]]])[ ]], dnl LAST-STATE @@ -1406,20 +1406,20 @@ dnl BISON-STDERR [AT_COND_CASE([[canonical LR]], [[input.y: warning: 1876 shift/reduce conflicts [-Wconflicts-sr] input.y: warning: 144 reduce/reduce conflicts [-Wconflicts-rr] -input.y:32.9-12: warning: useless associativity for HQUA [-Wother] -input.y:53.8-14: warning: useless associativity for HASSIGN [-Wother] -input.y:54.9-15: warning: useless associativity for HORELSE [-Wother] -input.y:55.9-16: warning: useless associativity for HANDTHEN [-Wother] -input.y:61.9-12: warning: useless associativity for HNOT [-Wother] -input.y:68.7-11: warning: useless associativity for UNEAR [-Wother]]], +input.y:32.9-12: warning: useless associativity for HQUA [-Wprecedence] +input.y:53.8-14: warning: useless associativity for HASSIGN [-Wprecedence] +input.y:54.9-15: warning: useless associativity for HORELSE [-Wprecedence] +input.y:55.9-16: warning: useless associativity for HANDTHEN [-Wprecedence] +input.y:61.9-12: warning: useless associativity for HNOT [-Wprecedence] +input.y:68.7-11: warning: useless associativity for UNEAR [-Wprecedence]]], [[input.y: warning: 78 shift/reduce conflicts [-Wconflicts-sr] input.y: warning: 10 reduce/reduce conflicts [-Wconflicts-rr] -input.y:32.9-12: warning: useless associativity for HQUA [-Wother] -input.y:53.8-14: warning: useless associativity for HASSIGN [-Wother] -input.y:54.9-15: warning: useless associativity for HORELSE [-Wother] -input.y:55.9-16: warning: useless associativity for HANDTHEN [-Wother] -input.y:61.9-12: warning: useless associativity for HNOT [-Wother] -input.y:68.7-11: warning: useless associativity for UNEAR [-Wother]]])[ +input.y:32.9-12: warning: useless associativity for HQUA [-Wprecedence] +input.y:53.8-14: warning: useless associativity for HASSIGN [-Wprecedence] +input.y:54.9-15: warning: useless associativity for HORELSE [-Wprecedence] +input.y:55.9-16: warning: useless associativity for HANDTHEN [-Wprecedence] +input.y:61.9-12: warning: useless associativity for HNOT [-Wprecedence] +input.y:68.7-11: warning: useless associativity for UNEAR [-Wprecedence]]])[ ]], dnl LAST-STATE @@ -2002,87 +2002,87 @@ dnl without being followed by "of".) dnl BISON-STDERR [[input.y:471.11-48: warning: rule useless in parser due to conflicts: path: ORDINAL LAST object_type relative_path [-Wother] -input.y:19.8-12: warning: useless associativity for LABEL [-Wother] -input.y:20.8-15: warning: useless associativity for VARIABLE [-Wother] -input.y:21.8-13: warning: useless associativity for NUMBER [-Wother] -input.y:22.8-11: warning: useless associativity for TEXT [-Wother] -input.y:25.8-14: warning: useless associativity for ORDINAL [-Wother] -input.y:30.8-11: warning: useless associativity for LAST [-Wother] -input.y:31.8-9: warning: useless associativity for UP [-Wother] -input.y:32.8-11: warning: useless associativity for DOWN [-Wother] -input.y:35.8-10: warning: useless associativity for BOX [-Wother] -input.y:36.8-13: warning: useless associativity for CIRCLE [-Wother] -input.y:37.8-14: warning: useless associativity for ELLIPSE [-Wother] -input.y:38.8-10: warning: useless associativity for ARC [-Wother] -input.y:39.8-11: warning: useless associativity for LINE [-Wother] -input.y:40.8-12: warning: useless associativity for ARROW [-Wother] -input.y:42.8-13: warning: useless associativity for SPLINE [-Wother] -input.y:43.8-13: warning: useless associativity for HEIGHT [-Wother] -input.y:44.8-13: warning: useless associativity for RADIUS [-Wother] -input.y:45.8-12: warning: useless associativity for WIDTH [-Wother] -input.y:46.8-15: warning: useless associativity for DIAMETER [-Wother] -input.y:47.8-11: warning: useless associativity for FROM [-Wother] -input.y:48.8-9: warning: useless associativity for TO [-Wother] -input.y:49.8-9: warning: useless associativity for AT [-Wother] -input.y:53.8-12: warning: useless associativity for SOLID [-Wother] -input.y:54.8-13: warning: useless associativity for DOTTED [-Wother] -input.y:55.8-13: warning: useless associativity for DASHED [-Wother] -input.y:56.8-11: warning: useless associativity for CHOP [-Wother] -input.y:59.8-12: warning: useless associativity for LJUST [-Wother] -input.y:60.8-12: warning: useless associativity for RJUST [-Wother] -input.y:61.8-12: warning: useless associativity for ABOVE [-Wother] -input.y:62.8-12: warning: useless associativity for BELOW [-Wother] -input.y:63.8-9: warning: useless associativity for OF [-Wother] -input.y:66.8-14: warning: useless associativity for BETWEEN [-Wother] -input.y:67.8-10: warning: useless associativity for AND [-Wother] -input.y:68.8-11: warning: useless associativity for HERE [-Wother] -input.y:69.8-12: warning: useless associativity for DOT_N [-Wother] -input.y:70.8-12: warning: useless associativity for DOT_E [-Wother] -input.y:71.8-12: warning: useless associativity for DOT_W [-Wother] -input.y:72.8-12: warning: useless associativity for DOT_S [-Wother] -input.y:73.8-13: warning: useless associativity for DOT_NE [-Wother] -input.y:74.8-13: warning: useless associativity for DOT_SE [-Wother] -input.y:75.8-13: warning: useless associativity for DOT_NW [-Wother] -input.y:76.8-13: warning: useless associativity for DOT_SW [-Wother] -input.y:77.8-12: warning: useless associativity for DOT_C [-Wother] -input.y:78.8-16: warning: useless associativity for DOT_START [-Wother] -input.y:79.8-14: warning: useless associativity for DOT_END [-Wother] -input.y:85.8-10: warning: useless associativity for SIN [-Wother] -input.y:86.8-10: warning: useless associativity for COS [-Wother] -input.y:87.8-12: warning: useless associativity for ATAN2 [-Wother] -input.y:88.8-10: warning: useless associativity for LOG [-Wother] -input.y:89.8-10: warning: useless associativity for EXP [-Wother] -input.y:90.8-11: warning: useless associativity for SQRT [-Wother] -input.y:91.8-12: warning: useless associativity for K_MAX [-Wother] -input.y:92.8-12: warning: useless associativity for K_MIN [-Wother] -input.y:93.8-10: warning: useless associativity for INT [-Wother] -input.y:94.8-11: warning: useless associativity for RAND [-Wother] -input.y:95.8-12: warning: useless associativity for SRAND [-Wother] -input.y:98.8-10: warning: useless associativity for TOP [-Wother] -input.y:99.8-13: warning: useless associativity for BOTTOM [-Wother] -input.y:100.8-12: warning: useless associativity for UPPER [-Wother] -input.y:101.8-12: warning: useless associativity for LOWER [-Wother] -input.y:116.8-18: warning: useless associativity for LEFT_CORNER [-Wother] -input.y:117.8-19: warning: useless associativity for RIGHT_CORNER [-Wother] -input.y:118.8-12: warning: useless associativity for NORTH [-Wother] -input.y:119.8-12: warning: useless associativity for SOUTH [-Wother] -input.y:120.8-11: warning: useless associativity for EAST [-Wother] -input.y:121.8-11: warning: useless associativity for WEST [-Wother] -input.y:122.8-13: warning: useless associativity for CENTER [-Wother] -input.y:123.8-10: warning: useless associativity for END [-Wother] -input.y:124.8-12: warning: useless associativity for START [-Wother] -input.y:127.8-11: warning: useless associativity for PLOT [-Wother] -input.y:128.8-16: warning: useless associativity for THICKNESS [-Wother] -input.y:129.8-11: warning: useless associativity for FILL [-Wother] -input.y:130.8-14: warning: useless associativity for COLORED [-Wother] -input.y:131.8-15: warning: useless associativity for OUTLINED [-Wother] -input.y:134.8-14: warning: useless associativity for SPRINTF [-Wother] -input.y:137.7-9: warning: useless associativity for '.' [-Wother] -input.y:156.23-25: warning: useless associativity for '(' [-Wother] -input.y:157.20-22: warning: useless associativity for '`' [-Wother] -input.y:159.48-50: warning: useless associativity for '@<:@' [-Wother] -input.y:170.7-9: warning: useless associativity for ',' [-Wother] -input.y:181.8-10: warning: useless associativity for '!' [-Wother] +input.y:19.8-12: warning: useless associativity for LABEL [-Wprecedence] +input.y:20.8-15: warning: useless associativity for VARIABLE [-Wprecedence] +input.y:21.8-13: warning: useless associativity for NUMBER [-Wprecedence] +input.y:22.8-11: warning: useless associativity for TEXT [-Wprecedence] +input.y:25.8-14: warning: useless associativity for ORDINAL [-Wprecedence] +input.y:30.8-11: warning: useless associativity for LAST [-Wprecedence] +input.y:31.8-9: warning: useless associativity for UP [-Wprecedence] +input.y:32.8-11: warning: useless associativity for DOWN [-Wprecedence] +input.y:35.8-10: warning: useless associativity for BOX [-Wprecedence] +input.y:36.8-13: warning: useless associativity for CIRCLE [-Wprecedence] +input.y:37.8-14: warning: useless associativity for ELLIPSE [-Wprecedence] +input.y:38.8-10: warning: useless associativity for ARC [-Wprecedence] +input.y:39.8-11: warning: useless associativity for LINE [-Wprecedence] +input.y:40.8-12: warning: useless associativity for ARROW [-Wprecedence] +input.y:42.8-13: warning: useless associativity for SPLINE [-Wprecedence] +input.y:43.8-13: warning: useless associativity for HEIGHT [-Wprecedence] +input.y:44.8-13: warning: useless associativity for RADIUS [-Wprecedence] +input.y:45.8-12: warning: useless associativity for WIDTH [-Wprecedence] +input.y:46.8-15: warning: useless associativity for DIAMETER [-Wprecedence] +input.y:47.8-11: warning: useless associativity for FROM [-Wprecedence] +input.y:48.8-9: warning: useless associativity for TO [-Wprecedence] +input.y:49.8-9: warning: useless associativity for AT [-Wprecedence] +input.y:53.8-12: warning: useless associativity for SOLID [-Wprecedence] +input.y:54.8-13: warning: useless associativity for DOTTED [-Wprecedence] +input.y:55.8-13: warning: useless associativity for DASHED [-Wprecedence] +input.y:56.8-11: warning: useless associativity for CHOP [-Wprecedence] +input.y:59.8-12: warning: useless associativity for LJUST [-Wprecedence] +input.y:60.8-12: warning: useless associativity for RJUST [-Wprecedence] +input.y:61.8-12: warning: useless associativity for ABOVE [-Wprecedence] +input.y:62.8-12: warning: useless associativity for BELOW [-Wprecedence] +input.y:63.8-9: warning: useless associativity for OF [-Wprecedence] +input.y:66.8-14: warning: useless associativity for BETWEEN [-Wprecedence] +input.y:67.8-10: warning: useless associativity for AND [-Wprecedence] +input.y:68.8-11: warning: useless associativity for HERE [-Wprecedence] +input.y:69.8-12: warning: useless associativity for DOT_N [-Wprecedence] +input.y:70.8-12: warning: useless associativity for DOT_E [-Wprecedence] +input.y:71.8-12: warning: useless associativity for DOT_W [-Wprecedence] +input.y:72.8-12: warning: useless associativity for DOT_S [-Wprecedence] +input.y:73.8-13: warning: useless associativity for DOT_NE [-Wprecedence] +input.y:74.8-13: warning: useless associativity for DOT_SE [-Wprecedence] +input.y:75.8-13: warning: useless associativity for DOT_NW [-Wprecedence] +input.y:76.8-13: warning: useless associativity for DOT_SW [-Wprecedence] +input.y:77.8-12: warning: useless associativity for DOT_C [-Wprecedence] +input.y:78.8-16: warning: useless associativity for DOT_START [-Wprecedence] +input.y:79.8-14: warning: useless associativity for DOT_END [-Wprecedence] +input.y:85.8-10: warning: useless associativity for SIN [-Wprecedence] +input.y:86.8-10: warning: useless associativity for COS [-Wprecedence] +input.y:87.8-12: warning: useless associativity for ATAN2 [-Wprecedence] +input.y:88.8-10: warning: useless associativity for LOG [-Wprecedence] +input.y:89.8-10: warning: useless associativity for EXP [-Wprecedence] +input.y:90.8-11: warning: useless associativity for SQRT [-Wprecedence] +input.y:91.8-12: warning: useless associativity for K_MAX [-Wprecedence] +input.y:92.8-12: warning: useless associativity for K_MIN [-Wprecedence] +input.y:93.8-10: warning: useless associativity for INT [-Wprecedence] +input.y:94.8-11: warning: useless associativity for RAND [-Wprecedence] +input.y:95.8-12: warning: useless associativity for SRAND [-Wprecedence] +input.y:98.8-10: warning: useless associativity for TOP [-Wprecedence] +input.y:99.8-13: warning: useless associativity for BOTTOM [-Wprecedence] +input.y:100.8-12: warning: useless associativity for UPPER [-Wprecedence] +input.y:101.8-12: warning: useless associativity for LOWER [-Wprecedence] +input.y:116.8-18: warning: useless associativity for LEFT_CORNER [-Wprecedence] +input.y:117.8-19: warning: useless associativity for RIGHT_CORNER [-Wprecedence] +input.y:118.8-12: warning: useless associativity for NORTH [-Wprecedence] +input.y:119.8-12: warning: useless associativity for SOUTH [-Wprecedence] +input.y:120.8-11: warning: useless associativity for EAST [-Wprecedence] +input.y:121.8-11: warning: useless associativity for WEST [-Wprecedence] +input.y:122.8-13: warning: useless associativity for CENTER [-Wprecedence] +input.y:123.8-10: warning: useless associativity for END [-Wprecedence] +input.y:124.8-12: warning: useless associativity for START [-Wprecedence] +input.y:127.8-11: warning: useless associativity for PLOT [-Wprecedence] +input.y:128.8-16: warning: useless associativity for THICKNESS [-Wprecedence] +input.y:129.8-11: warning: useless associativity for FILL [-Wprecedence] +input.y:130.8-14: warning: useless associativity for COLORED [-Wprecedence] +input.y:131.8-15: warning: useless associativity for OUTLINED [-Wprecedence] +input.y:134.8-14: warning: useless associativity for SPRINTF [-Wprecedence] +input.y:137.7-9: warning: useless associativity for '.' [-Wprecedence] +input.y:156.23-25: warning: useless associativity for '(' [-Wprecedence] +input.y:157.20-22: warning: useless associativity for '`' [-Wprecedence] +input.y:159.48-50: warning: useless associativity for '@<:@' [-Wprecedence] +input.y:170.7-9: warning: useless associativity for ',' [-Wprecedence] +input.y:181.8-10: warning: useless associativity for '!' [-Wprecedence] ]], dnl LAST-STATE diff --git a/tests/local.at b/tests/local.at index f3cc933..4795617 100644 --- a/tests/local.at +++ b/tests/local.at @@ -962,7 +962,7 @@ yylex (void) m4_if(m4_index(m4_quote($3), [no-xml]), -1, [AT_BISON_CHECK], - [AT_BISON_CHECK_NO_XML])([[--report=all --defines -o input.c input.y]], + [AT_BISON_CHECK_NO_XML])([[-Wall --report=all --defines -o input.c input.y]], [0], [], m4_dquote($7)) m4_if(m4_index(m4_quote($3), [last-state]), -1, diff --git a/tests/regression.at b/tests/regression.at index 7a5ed3e..b7dacb0 100644 --- a/tests/regression.at +++ b/tests/regression.at @@ -377,9 +377,9 @@ exp: ; %% ]]) -AT_BISON_CHECK([-v -o input.c input.y], 0, [], -[[input.y:1.29-32: warning: useless associativity for "||" [-Wother] -input.y:2.29-32: warning: useless associativity for "<=" [-Wother] +AT_BISON_CHECK([-v -Wall -o input.c input.y], 0, [], +[[input.y:1.29-32: warning: useless associativity for "||" [-Wprecedence] +input.y:2.29-32: warning: useless associativity for "<=" [-Wprecedence] ]]) AT_CLEANUP @@ -1147,10 +1147,10 @@ sr_conflict: ]]) AT_BISON_OPTION_POPDEFS -AT_BISON_CHECK([[-o input.c input.y]], [[0]],, +AT_BISON_CHECK([[-Wall -o input.c input.y]], [[0]],, [[input.y:24.5-19: warning: rule useless in parser due to conflicts: start: start [-Wother] input.y:28.5-19: warning: rule useless in parser due to conflicts: sr_conflict: TK2 "tok alias" [-Wother] -input.y:18.7-9: warning: useless associativity for TK1 [-Wother] +input.y:18.7-9: warning: useless associativity for TK1 [-Wprecedence] ]]) AT_COMPILE([[input]]) AT_PARSER_CHECK([[./input]]) -- 1.7.9.5