[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/2] tests: New associativity warning test, and testsuite sanitiz
From: |
Valentin Tolmer |
Subject: |
[PATCH 2/2] tests: New associativity warning test, and testsuite sanitizing |
Date: |
Wed, 30 Jan 2013 10:26:54 +0100 |
Due to the new warning, a lot of tests had to be updated.
* tests/conflicts.at (Useless associativity warning): New.
* tests/conflicts.at tests/existing.at tests/regression.at:
Testsuite sanitizing. Added the associativity warning in the expected
results.
* tests/java.at: Corrected the java calculator's grammar to remove a useless
associativity.
---
tests/conflicts.at | 43 ++++++++++++++++
tests/existing.at | 137 +++++++++++++++++++++++++++++++++++++++++++++++++--
tests/java.at | 6 +--
tests/regression.at | 6 ++-
4 files changed, 184 insertions(+), 8 deletions(-)
diff --git a/tests/conflicts.at b/tests/conflicts.at
index 88eb284..f03ba1e 100644
--- a/tests/conflicts.at
+++ b/tests/conflicts.at
@@ -17,6 +17,38 @@
AT_BANNER([[Conflicts.]])
+## ----------------------------- ##
+## Useless associativity warning. ##
+## ----------------------------- ##
+
+AT_SETUP([Useless associativity warning])
+
+AT_DATA([[input.y]],
+[[%token T
+%left A B
+%right C
+%nonassoc D
+%precedence E
+
+%%
+e: T A T
+ | T B T
+ | T C T
+ | T D T
+ | T E T
+;
+]])
+
+AT_BISON_CHECK([input.y], 0, [],
+[[input.y:5.13: warning: useless precedence for E [-Wother]
+input.y:2.9: warning: useless associativity for B [-Wother]
+input.y:2.7: warning: useless associativity for A [-Wother]
+input.y:3.8: warning: useless associativity for C [-Wother]
+input.y:4.11: warning: useless associativity for D [-Wother]
+]])
+
+AT_CLEANUP
+
## --------------------------- ##
## Useless precedence warning. ##
@@ -56,6 +88,15 @@ AT_BISON_CHECK([-fcaret -o input.c input.y], 0, [],
[[input.y:2.13: warning: useless precedence for Z [-Wother]
%precedence Z
^
+input.y:5.7: warning: useless associativity for W [-Wother]
+ %left W
+ ^
+input.y:6.8: warning: useless associativity for V [-Wother]
+ %right V
+ ^
+input.y:7.11: warning: useless associativity for U [-Wother]
+ %nonassoc U
+ ^
]])
AT_CLEANUP
@@ -1092,6 +1133,8 @@ e: e '+' e
AT_BISON_CHECK([-o input.c input.y], 0, [],
[[input.y: warning: 4 shift/reduce conflicts [-Wconflicts-sr]
+input.y:1.7-9: warning: useless associativity for '+' [-Wother]
+input.y:2.7-9: warning: useless associativity for '*' [-Wother]
]])
AT_CLEANUP
diff --git a/tests/existing.at b/tests/existing.at
index 9d30479..8482014 100644
--- a/tests/existing.at
+++ b/tests/existing.at
@@ -427,8 +427,44 @@ dnl don't like even `print $!4;'.
dnl BISON-STDERR
[AT_COND_CASE([[canonical LR]],
-[[input.y: warning: 265 shift/reduce conflicts [-Wconflicts-sr]]],
-[[input.y: warning: 65 shift/reduce conflicts [-Wconflicts-sr]]])[
+[[input.y: warning: 265 shift/reduce conflicts [-Wconflicts-sr]
+input.y:18.8-16: warning: useless associativity for FUNC_CALL [-Wother]
+input.y:20.8-14: warning: useless associativity for YNUMBER [-Wother]
+input.y:20.16-22: warning: useless associativity for YSTRING [-Wother]
+input.y:21.14-22: warning: useless associativity for APPEND_OP [-Wother]
+input.y:22.8-15: warning: useless associativity for ASSIGNOP [-Wother]
+input.y:22.33-41: warning: useless associativity for CONCAT_OP [-Wother]
+input.y:26.8-18: warning: useless associativity for LEX_GETLINE [-Wother]
+input.y:27.8-13: warning: useless associativity for LEX_IN [-Wother]
+input.y:28.23-31: warning: useless associativity for INCREMENT [-Wother]
+input.y:28.33-41: warning: useless associativity for DECREMENT [-Wother]
+input.y:29.8-18: warning: useless associativity for LEX_BUILTIN [-Wother]
+input.y:29.20-29: warning: useless associativity for LEX_LENGTH [-Wother]
+input.y:39.11-13: warning: useless associativity for ',' [-Wother]
+input.y:46.8-10: warning: useless associativity for '!' [-Wother]
+input.y:46.12-16: warning: useless associativity for UNARY [-Wother]
+input.y:49.7-9: warning: useless associativity for '$' [-Wother]
+input.y:50.7-9: warning: useless associativity for '(' [-Wother]
+input.y:50.11-13: warning: useless associativity for ')' [-Wother]]],
+[[input.y: warning: 65 shift/reduce conflicts [-Wconflicts-sr]
+input.y:18.8-16: warning: useless associativity for FUNC_CALL [-Wother]
+input.y:20.8-14: warning: useless associativity for YNUMBER [-Wother]
+input.y:20.16-22: warning: useless associativity for YSTRING [-Wother]
+input.y:21.14-22: warning: useless associativity for APPEND_OP [-Wother]
+input.y:22.8-15: warning: useless associativity for ASSIGNOP [-Wother]
+input.y:22.33-41: warning: useless associativity for CONCAT_OP [-Wother]
+input.y:26.8-18: warning: useless associativity for LEX_GETLINE [-Wother]
+input.y:27.8-13: warning: useless associativity for LEX_IN [-Wother]
+input.y:28.23-31: warning: useless associativity for INCREMENT [-Wother]
+input.y:28.33-41: warning: useless associativity for DECREMENT [-Wother]
+input.y:29.8-18: warning: useless associativity for LEX_BUILTIN [-Wother]
+input.y:29.20-29: warning: useless associativity for LEX_LENGTH [-Wother]
+input.y:39.11-13: warning: useless associativity for ',' [-Wother]
+input.y:46.8-10: warning: useless associativity for '!' [-Wother]
+input.y:46.12-16: warning: useless associativity for UNARY [-Wother]
+input.y:49.7-9: warning: useless associativity for '$' [-Wother]
+input.y:50.7-9: warning: useless associativity for '(' [-Wother]
+input.y:50.11-13: warning: useless associativity for ')' [-Wother]]])[
]],
dnl LAST-STATE
@@ -1369,9 +1405,21 @@ dnl INPUT
dnl BISON-STDERR
[AT_COND_CASE([[canonical LR]],
[[input.y: warning: 1876 shift/reduce conflicts [-Wconflicts-sr]
-input.y: warning: 144 reduce/reduce conflicts [-Wconflicts-rr]]],
+input.y: warning: 144 reduce/reduce conflicts [-Wconflicts-rr]
+input.y:31.9-12: warning: useless associativity for HQUA [-Wother]
+input.y:52.8-14: warning: useless associativity for HASSIGN [-Wother]
+input.y:53.9-15: warning: useless associativity for HORELSE [-Wother]
+input.y:54.9-16: warning: useless associativity for HANDTHEN [-Wother]
+input.y:60.9-12: warning: useless associativity for HNOT [-Wother]
+input.y:67.7-11: warning: useless associativity for UNEAR [-Wother]]],
[[input.y: warning: 78 shift/reduce conflicts [-Wconflicts-sr]
-input.y: warning: 10 reduce/reduce conflicts [-Wconflicts-rr]]])[
+input.y: warning: 10 reduce/reduce conflicts [-Wconflicts-rr]
+input.y:31.9-12: warning: useless associativity for HQUA [-Wother]
+input.y:52.8-14: warning: useless associativity for HASSIGN [-Wother]
+input.y:53.9-15: warning: useless associativity for HORELSE [-Wother]
+input.y:54.9-16: warning: useless associativity for HANDTHEN [-Wother]
+input.y:60.9-12: warning: useless associativity for HNOT [-Wother]
+input.y:67.7-11: warning: useless associativity for UNEAR [-Wother]]])[
]],
dnl LAST-STATE
@@ -1954,6 +2002,87 @@ dnl without being followed by "of".)
dnl BISON-STDERR
[[input.y:470.11-48: warning: rule useless in parser due to conflicts: path:
ORDINAL LAST object_type relative_path [-Wother]
+input.y:18.8-12: warning: useless associativity for LABEL [-Wother]
+input.y:19.8-15: warning: useless associativity for VARIABLE [-Wother]
+input.y:20.8-13: warning: useless associativity for NUMBER [-Wother]
+input.y:21.8-11: warning: useless associativity for TEXT [-Wother]
+input.y:24.8-14: warning: useless associativity for ORDINAL [-Wother]
+input.y:29.8-11: warning: useless associativity for LAST [-Wother]
+input.y:30.8-9: warning: useless associativity for UP [-Wother]
+input.y:31.8-11: warning: useless associativity for DOWN [-Wother]
+input.y:34.8-10: warning: useless associativity for BOX [-Wother]
+input.y:35.8-13: warning: useless associativity for CIRCLE [-Wother]
+input.y:36.8-14: warning: useless associativity for ELLIPSE [-Wother]
+input.y:37.8-10: warning: useless associativity for ARC [-Wother]
+input.y:38.8-11: warning: useless associativity for LINE [-Wother]
+input.y:39.8-12: warning: useless associativity for ARROW [-Wother]
+input.y:41.8-13: warning: useless associativity for SPLINE [-Wother]
+input.y:42.8-13: warning: useless associativity for HEIGHT [-Wother]
+input.y:43.8-13: warning: useless associativity for RADIUS [-Wother]
+input.y:44.8-12: warning: useless associativity for WIDTH [-Wother]
+input.y:45.8-15: warning: useless associativity for DIAMETER [-Wother]
+input.y:46.8-11: warning: useless associativity for FROM [-Wother]
+input.y:47.8-9: warning: useless associativity for TO [-Wother]
+input.y:48.8-9: warning: useless associativity for AT [-Wother]
+input.y:52.8-12: warning: useless associativity for SOLID [-Wother]
+input.y:53.8-13: warning: useless associativity for DOTTED [-Wother]
+input.y:54.8-13: warning: useless associativity for DASHED [-Wother]
+input.y:55.8-11: warning: useless associativity for CHOP [-Wother]
+input.y:58.8-12: warning: useless associativity for LJUST [-Wother]
+input.y:59.8-12: warning: useless associativity for RJUST [-Wother]
+input.y:60.8-12: warning: useless associativity for ABOVE [-Wother]
+input.y:61.8-12: warning: useless associativity for BELOW [-Wother]
+input.y:62.8-9: warning: useless associativity for OF [-Wother]
+input.y:65.8-14: warning: useless associativity for BETWEEN [-Wother]
+input.y:66.8-10: warning: useless associativity for AND [-Wother]
+input.y:67.8-11: warning: useless associativity for HERE [-Wother]
+input.y:68.8-12: warning: useless associativity for DOT_N [-Wother]
+input.y:69.8-12: warning: useless associativity for DOT_E [-Wother]
+input.y:70.8-12: warning: useless associativity for DOT_W [-Wother]
+input.y:71.8-12: warning: useless associativity for DOT_S [-Wother]
+input.y:72.8-13: warning: useless associativity for DOT_NE [-Wother]
+input.y:73.8-13: warning: useless associativity for DOT_SE [-Wother]
+input.y:74.8-13: warning: useless associativity for DOT_NW [-Wother]
+input.y:75.8-13: warning: useless associativity for DOT_SW [-Wother]
+input.y:76.8-12: warning: useless associativity for DOT_C [-Wother]
+input.y:77.8-16: warning: useless associativity for DOT_START [-Wother]
+input.y:78.8-14: warning: useless associativity for DOT_END [-Wother]
+input.y:84.8-10: warning: useless associativity for SIN [-Wother]
+input.y:85.8-10: warning: useless associativity for COS [-Wother]
+input.y:86.8-12: warning: useless associativity for ATAN2 [-Wother]
+input.y:87.8-10: warning: useless associativity for LOG [-Wother]
+input.y:88.8-10: warning: useless associativity for EXP [-Wother]
+input.y:89.8-11: warning: useless associativity for SQRT [-Wother]
+input.y:90.8-12: warning: useless associativity for K_MAX [-Wother]
+input.y:91.8-12: warning: useless associativity for K_MIN [-Wother]
+input.y:92.8-10: warning: useless associativity for INT [-Wother]
+input.y:93.8-11: warning: useless associativity for RAND [-Wother]
+input.y:94.8-12: warning: useless associativity for SRAND [-Wother]
+input.y:97.8-10: warning: useless associativity for TOP [-Wother]
+input.y:98.8-13: warning: useless associativity for BOTTOM [-Wother]
+input.y:99.8-12: warning: useless associativity for UPPER [-Wother]
+input.y:100.8-12: warning: useless associativity for LOWER [-Wother]
+input.y:115.8-18: warning: useless associativity for LEFT_CORNER [-Wother]
+input.y:116.8-19: warning: useless associativity for RIGHT_CORNER [-Wother]
+input.y:117.8-12: warning: useless associativity for NORTH [-Wother]
+input.y:118.8-12: warning: useless associativity for SOUTH [-Wother]
+input.y:119.8-11: warning: useless associativity for EAST [-Wother]
+input.y:120.8-11: warning: useless associativity for WEST [-Wother]
+input.y:121.8-13: warning: useless associativity for CENTER [-Wother]
+input.y:122.8-10: warning: useless associativity for END [-Wother]
+input.y:123.8-12: warning: useless associativity for START [-Wother]
+input.y:126.8-11: warning: useless associativity for PLOT [-Wother]
+input.y:127.8-16: warning: useless associativity for THICKNESS [-Wother]
+input.y:128.8-11: warning: useless associativity for FILL [-Wother]
+input.y:129.8-14: warning: useless associativity for COLORED [-Wother]
+input.y:130.8-15: warning: useless associativity for OUTLINED [-Wother]
+input.y:133.8-14: warning: useless associativity for SPRINTF [-Wother]
+input.y:136.7-9: warning: useless associativity for '.' [-Wother]
+input.y:155.23-25: warning: useless associativity for '(' [-Wother]
+input.y:156.20-22: warning: useless associativity for '`' [-Wother]
+input.y:158.48-50: warning: useless associativity for '@<:@' [-Wother]
+input.y:169.7-9: warning: useless associativity for ',' [-Wother]
+input.y:180.8-10: warning: useless associativity for '!' [-Wother]
]],
dnl LAST-STATE
diff --git a/tests/java.at b/tests/java.at
index 2a1ba51..b91cd98 100644
--- a/tests/java.at
+++ b/tests/java.at
@@ -54,11 +54,11 @@ AT_DATA([Calc.y],
%token <Integer> NUM "number"
%type <Integer> exp
-%nonassoc '=' /* comparison */
+%nonassoc '=' /* comparison */
%left '-' '+'
%left '*' '/'
-%left NEG /* negation--unary minus */
-%right '^' /* exponentiation */
+%precedence NEG /* negation--unary minus */
+%right '^' /* exponentiation */
/* Grammar follows */
%%
diff --git a/tests/regression.at b/tests/regression.at
index c08059e..86aec8e 100644
--- a/tests/regression.at
+++ b/tests/regression.at
@@ -377,7 +377,10 @@ exp: ;
%%
]])
-AT_BISON_CHECK([-v -o input.c input.y])
+AT_BISON_CHECK([-v -o input.c input.y], 0, [],
+[[input.y:1.29-32: warning: useless associativity for "||" [-Wother]
+input.y:2.29-32: warning: useless associativity for "<=" [-Wother]
+]])
AT_CLEANUP
@@ -1192,6 +1195,7 @@ AT_BISON_OPTION_POPDEFS
AT_BISON_CHECK([[-o input.c input.y]], [[0]],,
[[input.y:23.5-19: warning: rule useless in parser due to conflicts: start:
start [-Wother]
input.y:27.5-19: warning: rule useless in parser due to conflicts:
sr_conflict: TK2 "tok alias" [-Wother]
+input.y:17.7-9: warning: useless associativity for TK1 [-Wother]
]])
AT_COMPILE([[input]])
AT_PARSER_CHECK([[./input]])
--
1.7.9.5