[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] build: run checks in distinct directories
From: |
Théophile Ranquet |
Subject: |
Re: [PATCH 2/2] build: run checks in distinct directories |
Date: |
Fri, 14 Dec 2012 11:09:50 +0100 |
2012/12/12 Akim Demaille <address@hidden>:
>
> Le 12 déc. 2012 à 11:51, Theophile Ranquet <address@hidden> a écrit :
>
>> index f7a6471..48d8cfa 100644
>> --- a/tests/local.at
>> +++ b/tests/local.at
>> @@ -464,7 +464,7 @@ AT_BISON_CHECK_NO_XML($@)])
>> # --------------------------------------------------
>> # Low-level macro to run bison once.
>> m4_define([AT_BISON_CHECK_],
>> -[AT_CHECK(AT_QUELL_VALGRIND[[ bison ]]$@)])
>> +[AT_CHECK(AT_QUELL_VALGRIND[[$abs_top_builddir/tests/bison ]]$@)])
>
> This is wrong: installcheck will no longer work. The test suite must rely
> only on PATH. Fix PATH, not the test suite.
>
>> # AT_BISON_CHECK_WARNINGS(BISON_ARGS, [OTHER_AT_CHECK_ARGS])
>> @@ -515,7 +515,8 @@ fi]dnl
>> # when a tortured grammar's XML is known to be too large for xsltproc to
>> # handle.
>> m4_define([AT_BISON_CHECK_NO_XML],
>> -[AT_CHECK(m4_null_if([$2], [], [AT_QUELL_VALGRIND ])[[bison ]]$@)
>> +[AT_CHECK(m4_null_if([$2], [], [AT_QUELL_VALGRIND ])
>> + [[$abs_top_builddir/tests/bison ]]$@)
>
> Likewise. Besides, I'm pretty sure you broke the test here, with the
> extraneous \n.
Reverted these.
> I'd prefer that you use && instead of ;, and that you:
>
> RUN_TESTSUITE = \
> foo \
> bar \
> baz
>
> instead.
So, like this?
-# Move into tests/ so that testsuite.dir etc. be created there.
-RUN_TESTSUITE = $(TESTSUITE) -C tests $(TESTSUITEFLAGS)
+# Move into tests/ so that testsuite.dir etc. be created there. If a suffix is
+# specified, create it in a corresponding subdirectory of tests/.
+RUN_TESTSUITE = dir=tests/$$suf \
+ && (test -d $$dir || mkdir $$dir) \
+ && (test -f $$dir/atconfig \
+ || cp tests/atconfig $$dir) \
+ && (test -f $$dir/atlocal \
+ || cp tests/atlocal $$dir) \
+ && $(TESTSUITE) -C $$dir $(TESTSUITEFLAGS)
> Please, also prepare a patch where the names are more consistent, and
> README-hacking is updated to reflect these changes.
On second thoughts, I like the difference in names. The task
accomplished by maintainer-{push,xml}-check really is on a different
level from that accomplished by maintainer -check-*. However, we might
want to consider the following, if there is no real motivation to keep
the 'push' and the 'xml' checks distinct.
.PHONY: maintainer-release-check
-maintainer-release-check: maintainer-check maintainer-push-check
maintainer-xml-check
+maintainer-release-check:
+ $(MAKE) $(AM_MAKEFLAGS) maintainer-check \
+ TESTSUITEFLAGS='BISON_TEST_XML=1 \
+ BISON_USE_PUSH_FOR_PULL=1 \
+ $(TESTSUITEFLAGS)'