Re: [PATCH 3/6] graphs: style: use left justification for states

[Akim Demaille]

Le 11 oct. 2012 à 16:39, Théophile Ranquet a écrit :

> 2012/10/11 Théophile Ranquet <address@hidden>:
>>> I installed those two, thanks.  There are a couple of
>>> stylistic issues (and C90 compliance) to address, please
>>> send a fix here.
>> 
>> Here is a fix, for that and a mistake in NEWS.
> 
> ... resent.

Thanks, installed.  But without the NEWS part,
with the following commit message, and the appended
additional changes:

commit c4ebd713636e6eaa618ef697e909310a27872b9b
Author: Theophile Ranquet <address@hidden>
Date:   Thu Oct 11 16:09:03 2012 +0000

    graphs: minor style changes
    
    * src/graphviz.c (output_red): Fix C90 issues.
    Reduce variable scopes.
    
    Signed-off-by: Akim Demaille <address@hidden>

diff --git a/src/graphviz.c b/src/graphviz.c
index b37a28e..e62ee1d 100644
--- a/src/graphviz.c
+++ b/src/graphviz.c
@@ -144,12 +144,12 @@ output_red (state const *s, reductions const *reds, FILE 
*fout)
         }
       obstack_sgrow (&oout, "\" style=solid]\n");
 
-      /* Then, print the reduction's representation. This most be done later
-         because the we need the previously determined boolean to know if this
-         reduction is disabled or not. */
-      obstack_printf (&oout, " \"%dR%d\" "
-                             "[style=filled shape=diamond fillcolor=%s "
-                             "label=\"R%d\"]\n",
+      /* Then, print the reduction's representation. Done later since
+         we need to know whether this reduction is disabled. */
+      obstack_printf (&oout,
+                      " \"%dR%d\" "
+                      "[style=filled shape=diamond fillcolor=%s "
+                      "label=\"R%d\"]\n",
                       source, ruleno,
                       disabled ? "firebrick1" : "yellowgreen",
                       ruleno);