Re: [PATCH] maint: fix an erroneous include

[Akim Demaille]

Le 3 oct. 2012 à 17:26, Theophile Ranquet a écrit :

> This fixes test 130 of the testsuite.
> 
> * NEWS: Document this.
> * data/location.cc: Include <iostream> rather than <iosfwd>.

Thanks!

Please note that "130" is a moving value, and that…

> --- a/NEWS
> +++ b/NEWS
> @@ -4,7 +4,9 @@ GNU Bison NEWS
> 
> ** Bug fixes
> 
> -  Bugs in the test suite have been fixed.
> +  Bugs in the test suite have been fixed. This includes a bug in test 130
> +  which was due to a bad include: <iosfwd> was causing trouble, <iostream>
> +  seems to be a safer bet.

what matters to the users is that the headers are self-contained,
not that the test that checks that passes.

So I installed this:

commit a2b3f10183008612c4350e072d5611e0b6a8a462
Author: Theophile Ranquet <address@hidden>
Date:   Wed Oct 3 15:26:56 2012 +0000

    maint: fix an erroneous include
    
    This fixes test 130 (Several parsers).
    
    * data/location.cc: Include <iostream> rather than <iosfwd> since
    we really need << on strings for instance.
    * NEWS: Document this.
    
    Signed-off-by: Akim Demaille <address@hidden>

diff --git a/NEWS b/NEWS
index ad5f738..c1ab7aa 100644
--- a/NEWS
+++ b/NEWS
@@ -14,6 +14,8 @@ GNU Bison NEWS
   Incorrect definitions of YY_, issued by yacc.c when no parser header is
   generated, are removed.
 
+  All the generated headers are self-contained.
+
 ** Changes in the format of error messages
 
   This used to be the format of many error reports:
@@ -1894,7 +1896,7 @@ along with this program.  If not, see 
<http://www.gnu.org/licenses/>.
  LocalWords:  namespaces strerror const autoconfiguration Dconst Autoconf's FDL
  LocalWords:  Automake TMPDIR LESSEQ ylwrap endif yydebug YYTOKEN YYLSP ival hh
  LocalWords:  extern YYTOKENTYPE TOKENTYPE yytokentype tokentype STYPE lval pdf
- LocalWords:  lang yyoutput dvi html ps POSIX lvalp llocp
+ LocalWords:  lang yyoutput dvi html ps POSIX lvalp llocp calc yyo fval
 
 Local Variables:
 mode: outline
diff --git a/data/location.cc b/data/location.cc
index b7383d6..0673f4c 100644
--- a/data/location.cc
+++ b/data/location.cc
@@ -30,7 +30,7 @@ b4_copyright([Positions for Bison parsers in C++],
 ]b4_cpp_guard_open([b4_dir_prefix[]position.hh])[
 
 # include <algorithm> // std::max
-# include <iosfwd>
+# include <iostream>
 # include <string>
 
 ]b4_null_define[