[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] use "unresolved reference" message
From: |
Joel E. Denny |
Subject: |
Re: [PATCH] use "unresolved reference" message |
Date: |
Sat, 5 Sep 2009 15:14:19 -0400 (EDT) |
User-agent: |
Alpine 1.00 (DEB 882 2007-12-20) |
Hi Alex.
On Sat, 5 Sep 2009, Alex Rozenman wrote:
> I pushed the following patch to master and to branch-2.5. It changes "symbol
> not found" messages
Thanks for dropping those.
> to "unresolved reference"
For the case where there are no valid referents, I think Bison should
consistently report "invalid reference". I don't see how "unresolved
reference" describes the subcase of no suggestions any better. A
suggestion is not a resolution, in my view.
> and fixes the problem of
> redundant reference suffix (.name and -name) shown after symbol name when no
> suggestions exist.
Now that you're consistently saying "reference" and not occasionally
"symbol", I don't understand the motivation for this change, which creates
an unintuitive distinction from all other error messages about references.
> I also added one additional test to the test-suite.
Thanks.
- [PATCH] use "unresolved reference" message, Alex Rozenman, 2009/09/05
- Re: [PATCH] use "unresolved reference" message,
Joel E. Denny <=
- Re: [PATCH] use "unresolved reference" message, Alex Rozenman, 2009/09/05
- Re: [PATCH] use "unresolved reference" message, Joel E. Denny, 2009/09/05
- Re: [PATCH] use "unresolved reference" message, Alex Rozenman, 2009/09/06
- Re: [PATCH] use "unresolved reference" message, Joel E. Denny, 2009/09/06
- Re: [PATCH] use "unresolved reference" message, Alex Rozenman, 2009/09/10
- Re: [PATCH] use "unresolved reference" message, Joel E. Denny, 2009/09/10
- Re: [PATCH] use "unresolved reference" message, Alex Rozenman, 2009/09/11
- Re: [PATCH] use "unresolved reference" message, Joel E. Denny, 2009/09/11
- Re: [PATCH] use "unresolved reference" message, Akim Demaille, 2009/09/16