Re: %define: accept unquoted values

[Akim Demaille]

Le 28 août 09 à 10:27, Joel E. Denny a écrit :

> Instead of this:
>
>  %define lr.type "LALR"
>  %define lr.type "IELR"
>  %define lr.type "canonical LR"
>
> I'd like to be able to write this:
>
>  %define lr.type lalr
>  %define lr.type ielr
>  %define lr.type canonical-lr
>
> There are two changes: (1) lr.type values are renamed so that they're
> spelled like lowercase IDs (which also look better with -D on the  
> command
> line), and (2) quotation marks on all %define values are optional  
> when the
> values are spelled like IDs.  I'm not sure why I didn't do this
> originally.
>
> The following two patches implement this.  Any objections?

I think this is a lot better.

> ChangeLog         |   15 +++++++++++++++
> NEWS              |    6 +++---
> doc/bison.texinfo |   10 +++++-----
> src/ielr.c        |    6 +++---
> src/ielr.h        |    6 +++---
> src/parse-gram.c  |    4 ++--
> src/parse-gram.h  |    2 +-
> src/reader.c      |    6 +++---
> tests/existing.at |    6 +++---
> tests/reduce.at   |   12 ++++++------

The ratio of actual code change wrt tests/doc/generated changes is  
most impressive.  I think you win, I cannot beat you at that game :)