Re: [PATCH] Miscellaneous code readability improvements.

[Joel E. Denny]

On Thu, 27 Aug 2009, Eric Blake wrote:

> char *s;     // if char is signed, and *s has 8th bit set,
> isspace(*s); // then *s promotes to int with sign extension, so you
>              // could be calling isspace(-2)

Ah, I clearly didn't give this enough thought.  Thanks for the thorough 
explanation.

> But for this particular context, I think you really do want to query whether 
> a 
> character is printable in the user's current locale.

Yes.

> > > * src/scan-gram.l (splice): Avoid compiler warning.
> > 
> > I would say the correct top-level construct is 
> > <SC_ESCAPED_STRING,SC_ESCAPED_CHARACTER> rather than splice.  git doesn't 
> > know how to read Flex specifications.
> 
> OK; I'll adjust that before pushing.

Please push.  Thanks.