Re: [PATCH] Fix "make distcheck".

[Akim Demaille]

Le 13 août 09 à 03:49, Joel E. Denny a écrit :

> Hi Akim.

Hi Joel,

> That makes sense to me, but I didn't think of it when I wrote my  
> patch,
> and, at that time, I didn't experience the problem that your patch  
> should
> fix.  If I'm understanding the situation, the explanation is ugly....
> [...]


Well, indeed :)

> It guess that means "make distcheck" has a limitation for my usage.   
> One
> possible fix would be for "make distcheck" to make the hierarchy  
> look like
> this instead:
>
>  bison.git/distcheck.tmp/bison-2.4.1.108-36df/_build

This would be nice, as it also simplifies cleaning of old tarballs,  
which are many now that we include the sha1 into the version.

> I'm now trying to think of ways to reproduce the behavior you saw.  I
> assume you didn't manually remove calc.stamp from your bison.git.   
> Are you
> separating the src and build directories even for your bison.git?  For
> example:
>
>  % cd ~/bison.git && git clean -dfx && ./bootstrap
>  % mkdir ~/bison.git-build && cd ~/bison.git-build
>  % ~/bison.git/configure && make && make distcheck

I'm using a deeper build "hierarchy": _build/{debug, speed,  
space, ...} depending on the compilation options.

> I'm expecting that we'll eventually reach at least one of the  
> following
> conclusions:
>
> 1. My build habits are wrong for automake.

Well, they are perfectly reasonable, and I know many people who use  
the same set up.  Including Automake itself in its distcheck  
sequence.  So it might be something to raise on the Automake lists.

If VPATH had been absolute, there would have been no problem.

> 2. I need to update my automake.
>
> 3. automake has a distcheck limitation that we should report.  It  
> seems
> there's a simple fix: it should push the distro directory down another
> level.

Yes, agreed.