Re: Help with create_pipe_bidi

[Akim Demaille]

Le 18 juil. 09 à 16:31, Eric Blake a écrit :

Hi Eric,

Thanks a lot for your help!

> @@ -151,7 +151,7 @@ gl_LIBOBJS=`echo "$gl_LIBOBJS" | sed -e 's, ,  
> lib/,g'`
> for ac_var in ALLOCA_H ERRNO_H FCNTL_H GETOPT_H INTTYPES_H \
>               STDBOOL_H STDINT_H SYS_WAIT_H WCHAR_H WCTYPE_H
> do
> -  eval "$ac_var=lib/\$$ac_var"
> +  eval "test 'x$ac_var' = x || $ac_var=lib/\$$ac_var"

This bit has been installed when I installed the patch.


> > From 4be36955e59b878adcb3231b445a71a6b4417e77 Mon Sep 17 00:00:00  
> > 2001
> From: Eric Blake <address@hidden>
> Date: Fri, 17 Jul 2009 22:15:27 -0600
> Subject: [PATCH 2/4] Import latest m4/m4.m4.
>
> * submodules/autoconf: Update.
> * configure.ac (M4_GNU_OPTION): New define.
> * src/output.c (output_skeleton): Use it to resolve FIXME.

This is good, please install.  In addition, please install an assert  
like

@@ -622,7 +624,9 @@ output_skeleton (void)
     argv[i++] = full_m4bison;
     argv[i++] = full_skeleton;
     argv[i++] = NULL;
+    assert(i <= sizeof argv / sizeof *argv);
   }
+
   /* When POSIXLY_CORRECT is set, some future versions of GNU M4  
(most likely
      2.0) may drop some of the GNU extensions that Bison's skeletons  
depend
      upon.  So that the next release of Bison is forward compatible  
with those



> > From 87a05fd87480aa2695e248346d293d9f263537a8 Mon Sep 17 00:00:00  
> > 2001
> From: Eric Blake <address@hidden>
> Date: Sat, 18 Jul 2009 06:24:59 -0600
> Subject: [PATCH 3/4] Import latest bootstrap script.
>
> * gnulib: Update.
> * bootstrap: Copy from gnulib, plus a one-line change.

This is not right: we have several changes in our bootstrap, which you  
completely dropped.  I guess we were wrong making changes to it, and  
we need to submit the changes.  The diff between the two files is  
impressive, but it should not be too hard to find the relevant changes  
using git log.

> From 7acbb1cdbe3977444e237ebf0aed50ea178ad4b6 Mon Sep 17 00:00:00 2001
> From: Eric Blake <address@hidden>
> Date: Sat, 18 Jul 2009 08:19:01 -0600
> Subject: [PATCH 4/4] Use pipe module for more robust m4 subprocess.
>
> * bootstrap.conf (gnulib_modules): Add pipe.
> * configure.ac: Adjust to gnulib update.
> * src/output.c (output_skeleton): Use gnulib functions.
> * lib/local.mk (lib_libbison_a_SOURCES): Drop subpipe.
> * .gitignore, lib/cvsignore, lib/.gitignore, m4/.cvsignore,
> * m4/.gitignore: Regen.

It seems that Bruno and Paolo are crafting a better suited pipe- 
filter, right?  I don't know if the thread ended on a consensus on the  
module to add to gnulib.