Re: [PATCH] Remove tests/Makefile.am.

[Eric Blake]

Akim Demaille <demaille <at> gostai.com> writes:

[visiting an older patch...]

> 
>       * tests/Makefile.am: Rename as...
>       * tests/local.mk: this.
>       * Makefile.am, configure.ac: Adjust.
>       * Makefile.am (DISTCLEANFILES): Define.
>       (maintainer-check, maintainer-xml-check, maintainer-push-check):
>       Remove, we no longer need to bounce to the real targets.
> +clean-local: clean-local-tests
> +clean-local-tests:
> +     test ! -f $(TESTSUITE) || cd tests && ../$(TESTSUITE) --clean
> +
> +check-local: tests/atconfig tests/atlocal $(TESTSUITE)
> +# Move into tests/ so that testsuite.dir etc. be created there.
> +     cd tests && ../$(TESTSUITE) $(TESTSUITEFLAGS)

This would be a perfect place to use '$(TESTSUITE) -C tests' rather than 'cd 
tests && ../$(TESTSUITE)'.  The latter is buggy since you don't deal with 
CDPATH, so it might produce spurious output (cd ./tests is safer).

On the other hand, autoconf only added support for testsuite -C in 2.62, so you 
would be requiring a newer version than the current AC_PREREQ([2.61]) in 
configure.ac.

-- 
Eric Blake