Re: [PATCH] Handles several --enable-gcc-warnings

[Akim Demaille]

Le 17 nov. 08 à 01:58, Di-an JAN a écrit :

> This patch handles reasonable warnings from --enable-gcc-warnings.
> It renames a muscle-producing function to use the prepare_* convention
> as it's not a output-producing *_output function.
>
> Tested on Cygwin on top of my previous patches with ``make check''
> with one expected error.
>
> I also get a warning for value = "" but the string pointed to is not  
> changed
> beyond that point.  The code doesn't seen wrong, so I didn't try to  
> ``fix'' it.
>
> src/getargs.c: In function `getargs':
> src/getargs.c:535: warning: assignment discards qualifiers from  
> pointer target type
>
>
>
> 2008-11-16  Di-an Jan  <address@hidden>
>
>         Handles several --enable-gcc-warnings.
>         * src/getargs.c (command_line_location): Set parameters to void.
>         * src/output.c (symbol_type_name_cmp): Make static.
>         (symbols_by_type_name): Set parameters to void.
>         (symbol_definitions_output): Remove unused parameter.  Rename as...
>         (prepare_symbol_definitions): this.
>         (muscles_output): Move symbol_definitions_output to...
>         (output): here as prepare_symbol_definitions.
>         * tests/c++.at (AT_CHECK_VARIANTS): Remove unused parameters of main.
>         (AT_CHECK_NAMESPACE): Make unused parameter lloc unnamed.

Looks good.  I think you should apply it in 2.4.1.