Re: [PATCH] Destroy the lhs symbols after reduction.

[Akim Demaille]

Le 4 nov. 08 à 09:28, Paolo Bonzini a écrit :

> Akim Demaille wrote:
> > Le 21 juil. 08 à 11:39, Akim Demaille a écrit :
> >
> > >    * data/lalr1-fusion.cc (parse): After the user action, when in
> > >    variant mode, destroy the lhs symbols.
> >
> > This patch fixes the problem with the use of variants.
> > example/variant.yy works properly.
>
> But lalr1-fusion.cc is not referenced by example/variant.yy or c++- 
> skel.m4?

Yes, I have left the two skeletons sitting one next to the other so  
that I could bench them properly.  Yet in my development tree, I had  
actually lalr1.cc point to (symlink) lalr1-fusion.cc.  That's the way  
I checked the test suite was running correctly.

As a matter of fact, it is bench.pl which is the most suitable tool at  
this stage to play with the -fusion skeleton.

A later patch actually renames lalr1.cc as lalr1-split.cc and lalr1- 
fusion.cc as lalr1.cc.  Once I had all the evidence I needed to make  
sure a single-stack was an improvement over split-stacks, I kept it as  
lalr1.cc.